You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/02 21:44:10 UTC

[GitHub] [incubator-tvm] anijain2305 opened a new pull request #6619: [ConvertLayout] Fix Strided Slice

anijain2305 opened a new pull request #6619:
URL: https://github.com/apache/incubator-tvm/pull/6619


   While converting a network from NHWC to NCHW, we found that a conv2d was followed by strided_slice and it was erroring out. This PR ensures insertion of layout transform before the strided slice to correct the bug.
   
   With careful handling of begin, end and strides, one can prevent the insertion of layout transform in future to get better performance.
   @trevor-m 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] anijain2305 closed pull request #6619: [ConvertLayout] Fix Strided Slice

Posted by GitBox <gi...@apache.org>.
anijain2305 closed pull request #6619:
URL: https://github.com/apache/incubator-tvm/pull/6619


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] anijain2305 commented on pull request #6619: [ConvertLayout] Fix Strided Slice

Posted by GitBox <gi...@apache.org>.
anijain2305 commented on pull request #6619:
URL: https://github.com/apache/incubator-tvm/pull/6619#issuecomment-703156992


   #6621 is better


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] kevinthesun commented on pull request #6619: [ConvertLayout] Fix Strided Slice

Posted by GitBox <gi...@apache.org>.
kevinthesun commented on pull request #6619:
URL: https://github.com/apache/incubator-tvm/pull/6619#issuecomment-703022607


   Oops, similar PR but avoid layout conversion: https://github.com/apache/incubator-tvm/pull/6621


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org