You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "liyubin117 (via GitHub)" <gi...@apache.org> on 2023/10/30 07:58:25 UTC
[PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
liyubin117 opened a new pull request, #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78
As Flink 1.18 released, bump the flink version in elasticsearch connector with push_pr.yml and weekly.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
Posted by "liyubin117 (via GitHub)" <gi...@apache.org>.
liyubin117 commented on PR #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78#issuecomment-1784819400
@MartijnVisser I have updated CI yml files and pined commons-compress and snappy-java version for guaranteeing dependency convergence, PTAL, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
Posted by "liyubin117 (via GitHub)" <gi...@apache.org>.
liyubin117 commented on PR #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78#issuecomment-1785012806
@MartijnVisser CI has succeed.
[https://github.com/liyubin117/flink-connector-elasticsearch/actions/runs/6692027990](url)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
Posted by "liyubin117 (via GitHub)" <gi...@apache.org>.
liyubin117 commented on code in PR #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78#discussion_r1376042196
##########
.github/workflows/weekly.yml:
##########
@@ -35,12 +35,18 @@ jobs:
}, {
flink: 1.18-SNAPSHOT,
branch: main
+ }, {
+ flink: 1.19-SNAPSHOT,
+ branch: main
}, {
flink: 1.16.2,
branch: v3.0
}, {
flink: 1.17.1,
branch: v3.0
+ }, {
+ flink: 1.18.0,
+ branch: v3.0
Review Comment:
I found that you removed the 1.18.0 support in the following hotfix, and there are compilation failures indeed, so I will also remove the support. thanks for your reminds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
Posted by "liyubin117 (via GitHub)" <gi...@apache.org>.
liyubin117 commented on code in PR #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78#discussion_r1376042196
##########
.github/workflows/weekly.yml:
##########
@@ -35,12 +35,18 @@ jobs:
}, {
flink: 1.18-SNAPSHOT,
branch: main
+ }, {
+ flink: 1.19-SNAPSHOT,
+ branch: main
}, {
flink: 1.16.2,
branch: v3.0
}, {
flink: 1.17.1,
branch: v3.0
+ }, {
+ flink: 1.18.0,
+ branch: v3.0
Review Comment:
I found that you removed the 1.18.0 support in the follow hotfix, and there are compilation failures indeed, so I will
also remove the support. thanks for your reminds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78#discussion_r1376022350
##########
.github/workflows/weekly.yml:
##########
@@ -35,12 +35,18 @@ jobs:
}, {
flink: 1.18-SNAPSHOT,
branch: main
+ }, {
+ flink: 1.19-SNAPSHOT,
+ branch: main
}, {
flink: 1.16.2,
branch: v3.0
}, {
flink: 1.17.1,
branch: v3.0
+ }, {
+ flink: 1.18.0,
+ branch: v3.0
Review Comment:
Does the v3.0 branch support 1.18.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
Posted by "pgodowski (via GitHub)" <gi...@apache.org>.
pgodowski commented on PR #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78#issuecomment-1842605883
What is the expected timeline for having the flink-connector-elasticsearch7 [published](https://central.sonatype.com/artifact/org.apache.flink/flink-connector-elasticsearch7/versions), with the Flink 1.18 support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33379] Bump CI flink version on flink-connector-elasticsearch [flink-connector-elasticsearch]
Posted by "liyubin117 (via GitHub)" <gi...@apache.org>.
liyubin117 commented on code in PR #78:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/78#discussion_r1376042196
##########
.github/workflows/weekly.yml:
##########
@@ -35,12 +35,18 @@ jobs:
}, {
flink: 1.18-SNAPSHOT,
branch: main
+ }, {
+ flink: 1.19-SNAPSHOT,
+ branch: main
}, {
flink: 1.16.2,
branch: v3.0
}, {
flink: 1.17.1,
branch: v3.0
+ }, {
+ flink: 1.18.0,
+ branch: v3.0
Review Comment:
I found that you removed the 1.18.0 support in the following hotfix, and there are compilation failures indeed, so I will
also remove the support. thanks for your reminds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org