[GitHub] seojangho commented on a change in pull request #59: [NEMO-50] Carefully retry tasks in the scheduler

[GitBox <gi...@apache.org>]

seojangho commented on a change in pull request #59: [NEMO-50] Carefully retry tasks in the scheduler
URL: https://github.com/apache/incubator-nemo/pull/59#discussion_r199054500
 
 

 ##########
 File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/StageState.java
 ##########
 @@ -31,31 +35,17 @@ private StateMachine buildTaskStateMachine() {
     final StateMachine.Builder stateMachineBuilder = StateMachine.newBuilder();
 
     // Add states
-    stateMachineBuilder.addState(State.READY, "The stage has been created.");
-    stateMachineBuilder.addState(State.EXECUTING, "The stage is executing.");
+    stateMachineBuilder.addState(State.SCHEDULABLE, "This stage should be scheduled.");
 
 Review comment:
   We may update the state description. 'Scheduling a stage' is vague in this two-state scheme, since it will still stay on `SCHEDULABLE` even after the scheduler schedules the stage.
   
   One suggestion:
   ```
   Some tasks in this stage is not completed.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services