You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/24 01:52:31 UTC

[GitHub] [apisix-dashboard] SkyeYoung commented on a diff in pull request #2647: feat:Configure plug-ins to support this feature

SkyeYoung commented on code in PR #2647:
URL: https://github.com/apache/apisix-dashboard/pull/2647#discussion_r1002820704


##########
web/.eslintrc.js:
##########
@@ -15,13 +15,38 @@
  * limitations under the License.
  */
 module.exports = {
-  extends: [require.resolve('@umijs/fabric/dist/eslint')],
+  extends: [
+    require.resolve('@umijs/fabric/dist/eslint'),
+    'plugin:import/errors',
+    'plugin:import/warnings',
+  ],
+  plugins: ['simple-import-sort'],
   globals: {
     ANT_DESIGN_PRO_ONLY_DO_NOT_USE_IN_YOUR_PRODUCTION: true,
     page: true,
     REACT_APP_ENV: true,
   },
   rules: {
     '@typescript-eslint/naming-convention': 'off',
+    'import/no-unresolved': [2, { ignore: ['^@/', '^umi/', '^@@/'] }],
+    'sort-imports': 'off',
+    'import/order': 'off',

Review Comment:
   Both parts of the modification look fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org