You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "fmartelli (via GitHub)" <gi...@apache.org> on 2024/04/24 13:39:24 UTC

[PR] [SYNCOPE-1816] Enables LDAP parameters configuration for SPNEGO authentication module [syncope]

fmartelli opened a new pull request, #699:
URL: https://github.com/apache/syncope/pull/699

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1816] Enables LDAP parameters configuration for SPNEGO authentication module [syncope]

Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #699:
URL: https://github.com/apache/syncope/pull/699#discussion_r1577934259


##########
client/am/console/src/main/java/org/apache/syncope/client/console/wizards/AuthModuleWizardBuilder.java:
##########
@@ -174,19 +175,19 @@
         }
     }
 
-    protected class GoogleMfaAuthModuleConfLDAP extends WizardStep implements WizardModel.ICondition {
+    protected class AuthModuleConfLDAP extends WizardStep implements WizardModel.ICondition {

Review Comment:
   ## Inner class could be static
   
   AuthModuleConfLDAP could be made static, since the enclosing instance is used only in its constructor.
   
   [Show more details](https://github.com/apache/syncope/security/code-scanning/1582)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1816] Enables LDAP parameters configuration for SPNEGO authentication module [syncope]

Posted by "fmartelli (via GitHub)" <gi...@apache.org>.
fmartelli merged PR #699:
URL: https://github.com/apache/syncope/pull/699


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org