You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/08/03 02:36:43 UTC

[GitHub] [openwhisk-runtime-go] ningyougang opened a new pull request, #172: Upgrade gradle version

ningyougang opened a new pull request, #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172

   - [x] due to openwhisk repo's gradle is upgraded to 6.9, it is better to upgrade runtime as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] upgle commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
upgle commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203477715

   @ningyougang Does this error message also occur in the current master branch?
   > "The action did not return a dictionary or array" 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] style95 commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
style95 commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203441209

   I think this change is one big milestone and worth having a separate commit for this.
   How about merging this PR first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] ningyougang commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
ningyougang commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203502391

   Got your
   
   > understand. Since it is a change of core, all sub-runtime projects will have the same issue. Although the array return type is not supported yet, it is planned to be supported, so it seems that the message content modification can be dealt with in this PR for passing the test.
   
   Got your point, fixed here: https://github.com/apache/openwhisk-runtime-go/pull/172/files#diff-c67a70867d3e68d8c9b4a4aa4ae76dc9362d2047ac0615e531d3d1bcec579892R87


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] ningyougang commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
ningyougang commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203472758

   @style95 @upgle i have repened, but i am not sure when the case failed whether can merge this pr. e.g. below relative test case will be failed (I tested in my local)
   ```
   runtime.actionContainers.ActionLoopBasicTests > runtime proxy should run and report an error for function not returning a json object FAILED
       org.scalatest.exceptions.TestFailedException: Some({"error":"The action did not return a dictionary."}) was not equal to Some({"error":"The action did not return a dictionary or array."})
           at org.scalatest.MatchersHelper$.indicateFailure(MatchersHelper.scala:343)
           at org.scalatest.Matchers$ShouldMethodHelper$.shouldMatcher(Matchers.scala:6723)
           at org.scalatest.Matchers$AnyShouldWrapper.should(Matchers.scala:6759)
   ...
   ```
   The reason is 
   https://github.com/apache/openwhisk/pull/5290/files#diff-af225dd78c7ac7e8e1232021f772d725b544a00a87b747865af4f15eaa338768R176
   ![image](https://user-images.githubusercontent.com/11749867/182524644-effd192f-d282-4487-822a-7c41a281f0c8.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] upgle commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
upgle commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203459562

   Please reopen this PR. I also think this PR should be merged first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] upgle merged pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
upgle merged PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] ningyougang commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
ningyougang commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203436752

   Applied this pr's content to https://github.com/apache/openwhisk-runtime-go/pull/170/ due to this pr: https://github.com/apache/openwhisk/pull/5290
   
   Otherwise below test case will be failed
   ```
   runtime.actionContainers.ActionLoopBasicTests > runtime proxy should run and report an error for function not returning a json object FAILED
       org.scalatest.exceptions.TestFailedException: Some({"error":"The action did not return a dictionary."}) was not equal to Some({"error":"The action did not return a dictionary or array."})
           at org.scalatest.MatchersHelper$.indicateFailure(MatchersHelper.scala:343)
           at org.scalatest.Matchers$ShouldMethodHelper$.shouldMatcher(Matchers.scala:6723)
           at org.scalatest.Matchers$AnyShouldWrapper.should(Matchers.scala:6759)
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] ningyougang closed pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #172: Upgrade gradle version
URL: https://github.com/apache/openwhisk-runtime-go/pull/172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] ningyougang commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
ningyougang commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203478670

   > @ningyougang Does this error message also occur in the current master branch?
   > 
   > > "The action did not return a dictionary or array"
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] ningyougang commented on a diff in pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#discussion_r936185873


##########
build.gradle:
##########
@@ -18,6 +18,7 @@
 buildscript {
     repositories {
         jcenter()
+        mavenCentral()

Review Comment:
   Fix 
   ![image](https://user-images.githubusercontent.com/11749867/182512609-f2a9ca10-c855-402c-9e4e-d892fdce3d5d.png)
   `scalafmt-core` is deprecated in jcenter, should use `mavenCentral()`
   And need to keep jcenter() due to exist some lib needs this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] ningyougang commented on a diff in pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#discussion_r936183960


##########
golang1.17/Dockerfile:
##########
@@ -38,7 +38,7 @@ RUN echo "deb http://deb.debian.org/debian buster-backports main contrib non-fre
      librdkafka-dev=0.11.6-1.1 &&\
     # Cleanup apt data, we do not need them later on.
     apt-get clean && rm -rf /var/lib/apt/lists/* &&\
-    go get -u github.com/go-delve/delve/cmd/dlv@v1.8.1 &&\
+    go install github.com/go-delve/delve/cmd/dlv@v1.8.1 &&\

Review Comment:
   Fix issue
   ```
   go get: installing executables with 'go get' in module mode is deprecated.
   	Use 'go install pkg@version' instead.
   	For more information, see https://golang.org/doc/go-get-install-deprecation
   	or run 'go help get' or 'go help install'.
   # github.com/rivo/uniseg
   pkg/mod/github.com/rivo/uniseg@v0.3.1/properties.go:130:6: missing function body
   pkg/mod/github.com/rivo/uniseg@v0.3.1/properties.go:130:20: syntax error: unexpected [, expecting (
   note: module requires Go 1.18
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] ningyougang commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
ningyougang commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203436833

   So closed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-runtime-go] upgle commented on pull request #172: Upgrade gradle version

Posted by GitBox <gi...@apache.org>.
upgle commented on PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#issuecomment-1203491057

   understand. Since it is a change of core, all sub-runtime projects will have the same issue.
   Although the array return type is not supported yet, it is planned to be supported, so it seems that the message content modification can be dealt with in this PR for passing the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org