You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2019/05/13 12:54:18 UTC

[wicket] branch wicket-js-cleanup updated: JS removed obsolete debug reference

This is an automated email from the ASF dual-hosted git repository.

svenmeier pushed a commit to branch wicket-js-cleanup
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to refs/heads/wicket-js-cleanup by this push:
     new d76df74  JS removed obsolete debug reference
d76df74 is described below

commit d76df745338c366da04311d9d832c1170847fd79
Author: Sven Meier <sv...@apache.org>
AuthorDate: Mon May 13 14:49:34 2019 +0200

    JS removed obsolete debug reference
    
    updated comment for header contributions
---
 .../java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js     | 9 +++------
 wicket-core/src/test/js/all.html                                 | 1 -
 wicket-core/src/test/js/head.js                                  | 6 ------
 3 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index 8d168ee..1bc2ac8 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -1751,12 +1751,9 @@
 
 				// Parses the header contribution element (returns a DOM tree with the contribution)
 				parse: function (headerNode) {
-					// the header contribution is stored as CDATA section in the header-contribution element.
-					// even though we need to parse it (and we have aleady parsed the response), header
-					// contribution needs to be treated separately. The reason for this is that
-					// Konqueror crashes when it there is a <script element in the parsed string. So we
-					// need to replace that first
-
+					// the header contribution is stored as CDATA section in the header-contribution element,
+					// we need to parse it since each header contribution needs to be treated separately
+					
 					// get the header contribution text and unescape it if necessary
 					var text = Wicket.DOM.text(headerNode);
 
diff --git a/wicket-core/src/test/js/all.html b/wicket-core/src/test/js/all.html
index d22e5a9..1babc7a 100644
--- a/wicket-core/src/test/js/all.html
+++ b/wicket-core/src/test/js/all.html
@@ -13,7 +13,6 @@
     </script>
     <!--<script src="https://code.jquery.com/jquery-migrate-3.0.0.js"></script>-->
 	<script src="../../main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js"></script>
-	<script src="../../main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery-debug.js"></script>
 	<script type="text/javascript" src="qunit/qunit.js"></script>
 	<script type="text/javascript" src="qunit/jquery.mockjax.js"></script>
 	<script type="text/javascript" src="qunit/blanket.min.js"></script>
diff --git a/wicket-core/src/test/js/head.js b/wicket-core/src/test/js/head.js
index 9966749..921d5cc 100644
--- a/wicket-core/src/test/js/head.js
+++ b/wicket-core/src/test/js/head.js
@@ -87,12 +87,6 @@ jQuery(document).ready(function() {
 		equal(false, Wicket.Head.containsElement(scriptElement, 'unknown').contains, 'There shouldn\'t be an element with such attribute name');
 	});
 
-	test('Wicket.Head.containsElement - check existence of wicket-ajax-debug.js with "src"', function() {
-		var scriptElement = Wicket.Head.createElement('script');
-		scriptElement.src = "../../main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery-debug.js";
-		ok(Wicket.Head.containsElement(scriptElement, 'src').contains, 'There should be an element for wicket-ajax-debug.js');
-	});
-
 	test('Wicket.Head.containsElement - check existence of data/test.js with "src_"', function() {
 		var $script = jQuery('<script>', {
 			type: 'text/javascript',