You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/02/01 02:21:59 UTC
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review15983
-----------------------------------------------------------
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment34277>
# Utility function to run a command.
# If the command fails, the tutorial exits with a friendly message.
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment34278>
Great, it also looks like you could push the command echo'ing into run().
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment34279>
nice!
- Ben Mahler
On Jan. 31, 2013, 10:56 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 10:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See Summary.
>
> Also, we only run 'ant' once instead of twice.
>
>
> Diffs
> -----
>
> hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
> hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
> hadoop/hadoop-7698-1.patch PRE-CREATION
> hadoop/hadoop-gridmix.patch 903ff19d2278f09136a495919ea13062871970ad
>
> Diff: https://reviews.apache.org/r/9174/diff/
>
>
> Testing
> -------
>
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2
Posted by Vinod Kone <vi...@gmail.com>.
> On Feb. 1, 2013, 1:21 a.m., Ben Mahler wrote:
> > hadoop/TUTORIAL.sh, line 31
> > <https://reviews.apache.org/r/9174/diff/2-3/?file=253799#file253799line31>
> >
> > Great, it also looks like you could push the command echo'ing into run().
Thanks for the nudge. Cleaned up the code quite a bit as a consequence.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review15983
-----------------------------------------------------------
On Jan. 31, 2013, 10:56 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 10:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See Summary.
>
> Also, we only run 'ant' once instead of twice.
>
>
> Diffs
> -----
>
> hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
> hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
> hadoop/hadoop-7698-1.patch PRE-CREATION
> hadoop/hadoop-gridmix.patch 903ff19d2278f09136a495919ea13062871970ad
>
> Diff: https://reviews.apache.org/r/9174/diff/
>
>
> Testing
> -------
>
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
>
>
> Thanks,
>
> Vinod Kone
>
>