[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1562: EnginePublishVersionTask: remove unreachable code

[GitBox <gi...@apache.org>]

gaodayue commented on a change in pull request #1562: EnginePublishVersionTask: remove unreachable code
URL: https://github.com/apache/incubator-doris/pull/1562#discussion_r308515164
 
 

 ##########
 File path: be/src/olap/task/engine_publish_version_task.cpp
 ##########
 @@ -104,21 +104,11 @@ OLAPStatus EnginePublishVersionTask::finish() {
                 res = publish_status;
                 continue;
             }
-            if (publish_status == OLAP_SUCCESS || publish_status == OLAP_ERR_PUSH_VERSION_ALREADY_EXIST) {
-                LOG(INFO) << "publish version successfully on tablet. tablet=" << tablet->full_name()
-                          << ", transaction_id=" << transaction_id << ", version=" << version.first
-                          << ", res=" << publish_status;
-                // delete rowset from meta env, because add inc rowset alreay saved the rowset meta to tablet meta
-                RowsetMetaManager::remove(tablet->data_dir()->get_meta(), tablet->tablet_uid(), rowset->rowset_id());
-                // delete txn info
-            } else {
-                LOG(WARNING) << "fail to publish version on tablet. tablet=" << tablet->full_name().c_str()
 
 Review comment:
   the else clause is unreachable, please see the if statement at line 97

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org