You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/06/25 16:33:05 UTC
[jira] [Commented] (THRIFT-406) C++ Test suite cleanup

    [ https://issues.apache.org/jira/browse/THRIFT-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601269#comment-14601269 ] 

ASF GitHub Bot commented on THRIFT-406:
---------------------------------------

GitHub user cmhe opened a pull request:

    https://github.com/apache/thrift/pull/528

    THRIFT-406 Convert C++ Test to Boost::Test

    This converts all C++ test to Boost::Test, integrates the DenseProtocolTest as a test like the others and removes C asserts from the TMemoryBufferTest.
    
    Two test cases from DenseProtocolTest have to be commented, because they use the private vlqRead and vlqWrite Methods of apache::thrift::protocol::TDenseProtocol.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cmhe/thrift THRIFT-406

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #528
    
----
commit 61b3f0f229183f5800e0e5928f2fd64423fe642b
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-24T08:03:50Z

    THRIFT-406 Converted AllProtocolTests to Boost::Test
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit 41fc9e560756540e37974d57858c0dd2131c345a
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-24T14:17:14Z

    THRIFT-406 Converted DenseProtocolTest to Boost::Test and integrated into the test run.
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit d43593b2edf7c6f3c2d33eb21be0aa0d8361073b
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-25T08:07:19Z

    THRIFT-406 Converted DebugProtoTest to Boost::Test.
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit 33485d48278b4e3c1078dd553a468fe7a9f5381d
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-25T09:48:52Z

    THRIFT-406 Converted JSONProtoTest to Boost::Test.
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit 1e13bd974ac90394c0f526f27be24c3b0cd3c5e7
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-25T12:14:12Z

    THRIFT-406 Converted OptionalRequiredTest to Boost::Test.
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit 53cbcaa32d785588249411d7689159ed1523fcf5
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-25T12:24:51Z

    THRIFT-406 Converted RecursiveTest to Boost::Test.
    
    Sponsored-by: Roger Meier <r.meier@siemens.com
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit ffa4abae04e5a0b46aa841c0f47bd8633436c452
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-25T12:34:21Z

    THRIFT-406 Converted SpecializationTest to Boost::Test.
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit 2e4f6da39d924ac8f00278aeb3607a22072a5e9b
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-25T12:47:15Z

    THRIFT-406 Converted TFDTransportTest to Boost::Test.
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit 8c83472dd69dd6f071ee9beefc7d39cf2a88021e
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-25T13:06:06Z

    THRIFT-406 Removed C asserts from TMemoryBufferTest.
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

commit 32bd7f89de5f3ab5beda6f90d9c0ddd0ad473dad
Author: Claudius Heine <ch...@denx.de>
Date:   2015-06-25T13:11:28Z

    THRIFT-406 Converted TPipedTransportTest to Boost::Test.
    
    Sponsored-by: Roger Meier <r....@siemens.com>
    Signed-off-by: Claudius Heine <ch...@denx.de>

----


> C++ Test suite cleanup
> ----------------------
>
>                 Key: THRIFT-406
>                 URL: https://issues.apache.org/jira/browse/THRIFT-406
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.8
>            Reporter: Jérémie BORDIER
>
> Some unit tests are already ported to boost::unit_test, so let's finish the work, and maybe move them to lib/cpp/test for consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)