You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@gmail.com> on 2012/06/26 12:45:52 UTC
Review Request: FLUME-1322: ChannelProcessor should catch Throwable to work
around close() clobbering uncaught Exceptions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5582/
-----------------------------------------------------------
Review request for Flume and Arvind Prabhakar.
Description
-------
ChannelProcessor is eating exceptions. Here we catch Throwable to address the issue.
Also added in a small fix for FileChannel so it displays the name properly in the logs.
This addresses bug FLUME-1322.
https://issues.apache.org/jira/browse/FLUME-1322
Diffs
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java c703654
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 42991de
Diff: https://reviews.apache.org/r/5582/diff/
Testing
-------
Unit pass. Also, manual testing that an OutOfMemoryError gets printed to the logs in the middle of a Transaction (would not be printed before). Also checked that the FileChannel name gets printed to the logs during startup.
Thanks,
Mike Percy
Re: Review Request: FLUME-1322: ChannelProcessor should catch Throwable to
work around close() clobbering uncaught Exceptions
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5582/#review8584
-----------------------------------------------------------
Ship it!
Ship It!
- Arvind Prabhakar
On June 26, 2012, 10:45 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5582/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 10:45 a.m.)
>
>
> Review request for Flume and Arvind Prabhakar.
>
>
> Description
> -------
>
> ChannelProcessor is eating exceptions. Here we catch Throwable to address the issue.
>
> Also added in a small fix for FileChannel so it displays the name properly in the logs.
>
>
> This addresses bug FLUME-1322.
> https://issues.apache.org/jira/browse/FLUME-1322
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java c703654
> flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 42991de
>
> Diff: https://reviews.apache.org/r/5582/diff/
>
>
> Testing
> -------
>
> Unit pass. Also, manual testing that an OutOfMemoryError gets printed to the logs in the middle of a Transaction (would not be printed before). Also checked that the FileChannel name gets printed to the logs during startup.
>
>
> Thanks,
>
> Mike Percy
>
>