You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:27:37 UTC

[GitHub] [pulsar] lhotari edited a comment on pull request #10968: fix parseMessageMetadata error cause by not skip broker entry metadata

lhotari edited a comment on pull request #10968:
URL: https://github.com/apache/pulsar/pull/10968#issuecomment-863811422


   It seems that `skipBrokerEntryMetadataIfExist` is called separately in many locations in Pulsar code base, before calling `parseMessageMetadata` method. For example:
   
   https://github.com/apache/pulsar/blob/18f2f4a9c1dab7eec5c7c9590b76aca17ee1ead8/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java#L298-L313
   
   https://github.com/apache/pulsar/blob/202da117b529b24bdf9c994750266dac597294a8/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java#L2454-L2455
   
   https://github.com/apache/pulsar/blob/f25b4a520bb82c6a09d373c9d314ca8e55d1f57b/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java#L1670-L1671
   
   https://github.com/apache/pulsar/blob/f25b4a520bb82c6a09d373c9d314ca8e55d1f57b/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java#L1685-L1686
   
   It seems that this inconsistency would have to be resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org