[GitHub] [airflow] ephraimbuddy commented on pull request #20069: Add migration-wait-timeout to the helm chart

[GitBox <gi...@apache.org>]

ephraimbuddy commented on pull request #20069:
URL: https://github.com/apache/airflow/pull/20069#issuecomment-986752938


   > Question - what woudl be the cases where timing out on migration is "wrong" ? Wouls not that leave the DB in a state that is not expected ? However I think that one is fine to merge as long as we merge #18439 - because then instead of "hanging" migration you'd get hard failure (which is much better).
   > 
   > Is that the idea behind it ?
   
   Actually, there was a timeout in the helm chart until this change: https://github.com/apache/airflow/commit/bced2d750fad420a1f9e6dd1cf95641e9fce79e5(which is not released yet). So now, it doesn't wait for migration like before. 
   I added default=60 in the cli_parser but I can remove it if we want. I feel there would be no harm since it's just for checking migrations and would exit once the check is alright


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org