You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Nicolas Le Bas (Created) (JIRA)" <ji...@apache.org> on 2011/10/27 18:30:34 UTC
[jira] [Created] (AUTOTAG-14) decouple the generator from its
runtime implementations
decouple the generator from its runtime implementations
-------------------------------------------------------
Key: AUTOTAG-14
URL: https://issues.apache.org/jira/browse/AUTOTAG-14
Project: Tiles Autotag
Issue Type: Improvement
Affects Versions: 1.0.0
Reporter: Nicolas Le Bas
Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
The attached patch decouples these by:
* providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
* limiting the direct references to a single one (an implementation of AutotagRuntime)
* making this reference configurable in maven-autotag-plugin.
That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (AUTOTAG-14) decouple the generator from its
runtime implementations
Posted by "Nicolas Le Bas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Le Bas closed AUTOTAG-14.
---------------------------------
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Assignee: Mck SembWever
> Labels: features
> Fix For: 1.0.0
>
> Attachments: 0001-Decoupling-the-generator-from-the-runtime-in-autotag.patch
>
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AUTOTAG-14) decouple the generator from its
runtime implementations
Posted by "Nicolas Le Bas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147701#comment-13147701 ]
Nicolas Le Bas commented on AUTOTAG-14:
---------------------------------------
creating a patch file is no problem, I just couldn't attach it. The "Attach Files" command in "More Actions" was not there.
It is now, so here's the patch file.
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Assignee: Mck SembWever
> Labels: features
> Attachments: 0001-Decoupling-the-generator-from-the-runtime-in-autotag.patch
>
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AUTOTAG-14) decouple the generator from its
runtime implementations
Posted by "Mck SembWever (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mck SembWever resolved AUTOTAG-14.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.0.0
committed through git to trunk.
thanks for this work Nicolas!
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Assignee: Mck SembWever
> Labels: features
> Fix For: 1.0.0
>
> Attachments: 0001-Decoupling-the-generator-from-the-runtime-in-autotag.patch
>
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AUTOTAG-14) decouple the generator from its
runtime implementations
Posted by "Mck SembWever (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147924#comment-13147924 ]
Mck SembWever commented on AUTOTAG-14:
--------------------------------------
In that time i took a look into how to pull your changes into the apache git clone and `git svn dcommit` it from there.
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Assignee: Mck SembWever
> Labels: features
> Attachments: 0001-Decoupling-the-generator-from-the-runtime-in-autotag.patch
>
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AUTOTAG-14) decouple the generator from its
runtime implementations
Posted by "Mck SembWever (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147626#comment-13147626 ]
Mck SembWever commented on AUTOTAG-14:
--------------------------------------
`git format-patch origin/trunk` didn't work for you?
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Assignee: Mck SembWever
> Labels: features
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (AUTOTAG-14) decouple the generator
from its runtime implementations
Posted by "Mck SembWever (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147626#comment-13147626 ]
Mck SembWever edited comment on AUTOTAG-14 at 11/10/11 11:51 AM:
-----------------------------------------------------------------
`git format-patch origin/trunk` didn't work for you? (ref: http://www.apache.org/dev/git.html )
was (Author: michaelsembwever):
`git format-patch origin/trunk` didn't work for you?
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Assignee: Mck SembWever
> Labels: features
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AUTOTAG-14) decouple the generator from its
runtime implementations
Posted by "Nicolas Le Bas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Le Bas updated AUTOTAG-14:
----------------------------------
Attachment: 0001-Decoupling-the-generator-from-the-runtime-in-autotag.patch
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Assignee: Mck SembWever
> Labels: features
> Attachments: 0001-Decoupling-the-generator-from-the-runtime-in-autotag.patch
>
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (AUTOTAG-14) decouple the generator from its
runtime implementations
Posted by "Mck SembWever (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mck SembWever reassigned AUTOTAG-14:
------------------------------------
Assignee: Mck SembWever
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Assignee: Mck SembWever
> Labels: features
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AUTOTAG-14) decouple the generator from its
runtime implementations
Posted by "Nicolas Le Bas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AUTOTAG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Le Bas updated AUTOTAG-14:
----------------------------------
Somehow I can't find a way to attach a patch file, so I'm providing a link to github instead:
https://github.com/nlebas/tiles/tree/autotag-runtime
> decouple the generator from its runtime implementations
> -------------------------------------------------------
>
> Key: AUTOTAG-14
> URL: https://issues.apache.org/jira/browse/AUTOTAG-14
> Project: Tiles Autotag
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Labels: features
>
> Currently the generated classes include several direct references to one of 3 runtime libraries. Each of these depend heavily on its corresponding implentation of Tiles Request.
> The attached patch decouples these by:
> * providing an SPI to implement runtime libraries for autotag: the interface AutotagRuntime.
> * limiting the direct references to a single one (an implementation of AutotagRuntime)
> * making this reference configurable in maven-autotag-plugin.
> That way autotag can be used with new implementations of Tiles Request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira