You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2020/08/06 16:26:00 UTC
[jira] [Commented] (CALCITE-4081) Round-tripping a DECIMAL literal
through Planner -> RelToSqlConverter -> Planner throws validation error
[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172515#comment-17172515 ]
Julian Hyde commented on CALCITE-4081:
--------------------------------------
Why make {{isValidDecimalValue}} so permissive? If the value is null, or the type is not DECIMAL, it should just throw. Fail fast. Fewer lines of code. Less testing required.
I call this "over-defensive coding". It doesn't do anyone any favors.
> Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error
> --------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-4081
> URL: https://issues.apache.org/jira/browse/CALCITE-4081
> Project: Calcite
> Issue Type: Bug
> Reporter: Steven Talbot
> Assignee: Chunwei Lei
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.25.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Take the following SQL:
> SELECT CAST('11111111111111111111111111111111.111111' AS DECIMAL(38,6)) AS "num"
> And, in the default Calcite SQL dialect with all defaults, send it through Planner parse -> valiate -> rel to get a RelNode. The RelNode will have a Project with the "111111111111111.11111" literal in there as a RexLiteral with Decimal type.
>
> The use RelToSqlConverter to convert that RelNode back to SQL. The SQL now looks like
> SELECT 11111111111111111111111111111111.111111 AS "num"
>
> If you attempt to parse and validate that SQL, you get "Numeric literal '11111111111111111111111111111111.111111' out of range" throw by SqlValidatorImpl.validateLiteral()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)