You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/09 01:01:40 UTC
Review Request 61514: Removed moved/deleted CMake modules from
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61514/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
`External` and `PatchCommand` were consolidated to `3rdparty`, and
`VsBuildCommand` has already been deprecated and is unused.
Diffs
-----
3rdparty/libprocess/cmake/macros/External.cmake 5bc51bd3822677040ab03edd576c876b74bd8afc
3rdparty/libprocess/cmake/macros/PatchCommand.cmake 12ee3f177a490c9b2319ed865aa3bb73019dad0d
3rdparty/libprocess/cmake/macros/VsBuildCommand.bat 8d8f7c6a368d794438129965063e1d4a4fef063c
Diff: https://reviews.apache.org/r/61514/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61514: Removed moved/deleted CMake modules from
libprocess.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61514/#review184456
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 8, 2017, 6:01 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61514/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2017, 6:01 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `External` and `PatchCommand` were consolidated to `3rdparty`, and
> `VsBuildCommand` has already been deprecated and is unused.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/macros/External.cmake 5bc51bd3822677040ab03edd576c876b74bd8afc
> 3rdparty/libprocess/cmake/macros/PatchCommand.cmake 12ee3f177a490c9b2319ed865aa3bb73019dad0d
> 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat 8d8f7c6a368d794438129965063e1d4a4fef063c
>
>
> Diff: https://reviews.apache.org/r/61514/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>