[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414462#comment-16414462 ] 

Uwe Schindler commented on SOLR-12141:
--------------------------------------

Here is the fix for Windows:  [^SOLR-12141.patch] 
The reason for borkenness was the quotes around the comparison. If windows detects a plain number, then it compares it as number. But the quotes caused it to use alphabetical comparison.

I will quickly test linux, but the WIndows fix should be ready to commit.

> Solr does not start on Windows with Java 10
> -------------------------------------------
>
>                 Key: SOLR-12141
>                 URL: https://issues.apache.org/jira/browse/SOLR-12141
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>    Affects Versions: 7.0, 7.1, 7.2, 7.3
>         Environment: Windows 10 with Java 10+
>            Reporter: Uwe Schindler
>            Priority: Blocker
>             Fix For: 7.3
>
>         Attachments: SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD shell does not know any numerical comparisons, so it fails as "10" is alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait for a useful message by the Java VM on startup because of wrong class file format? This is too simply to break, especially as the output of "java -version" is not standardized (and changes with Java 10 to also have a date code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org