[GitHub] [skywalking-data-collect-protocol] mrproliu commented on a change in pull request #12: Profile report snapshot and finish status

[GitBox <gi...@apache.org>]

mrproliu commented on a change in pull request #12: Profile report snapshot and finish status
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/12#discussion_r365523023
 
 

 ##########
 File path: profile/Profile.proto
 ##########
 @@ -40,3 +50,32 @@ message ProfileTaskCommandQuery {
     // last commmand timestamp
     int64 lastCommandTime = 3;
 }
+
+// dumped segment snapshot
+message ProfileTaskSegemntSnapshot {
+    // profile task id
+    string taskId = 1;
+    // dumped segment id
+    UniqueId traceSegmentId = 2;
+    // dump timestamp
+    int64 time = 3;
+    // snapshot dump sequence, start with zero
+    int32 sequence = 4;
+    // snapshot stack bytes
+    bytes stack = 5;
 
 Review comment:
   I think it just needs storage to the backend, don't need to convert stack again. like you say, It 's dangerous, so change that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services