You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/07 03:21:17 UTC
[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new issue #1740:
Regularize Log print
Technoboy- opened a new issue #1740: Regularize Log print
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1740
Background:
Log print is not regular in all the DS module . like below :
```
logger.error("start Quartz failed : " + e.getMessage(), e);
```
Suggestion:
We should regularize the log print, using ”{}“ instead of ”+" :
```
# 1
logger.error("start Quartz failed ", e);
# 2
logger.error("delete queue : {} fail", queueId);
# 3
logger.error("complete task : {} with {} ms ", taskName, takesMS);
```
We should split module or package as a group to correct the log print, like 👍
1. org.apache.dolphinscheduler.api.configuration
2. org.apache.dolphinscheduler.api.controller
pull request should only correct log without any modification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Yeleights edited a comment on issue
#1740: Regularize Log print
Posted by GitBox <gi...@apache.org>.
Yeleights edited a comment on issue #1740: Regularize Log print
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1740#issuecomment-571417736
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- closed issue #1740:
Regularize Log print
Posted by GitBox <gi...@apache.org>.
Technoboy- closed issue #1740: Regularize Log print
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] nauu commented on issue #1740:
Regularize Log print
Posted by GitBox <gi...@apache.org>.
nauu commented on issue #1740: Regularize Log print
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1740#issuecomment-571695428
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Yeleights commented on issue #1740:
Regularize Log print
Posted by GitBox <gi...@apache.org>.
Yeleights commented on issue #1740: Regularize Log print
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1740#issuecomment-571417736
+1 join~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services