You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@buildr.apache.org by Antoine Toulme <an...@lunar-ocean.com> on 2010/03/17 07:19:12 UTC
Fwd: [jira] Updated: (BUILDR-401) Don't set compiler to output
warnings if verbose
Can we discuss this issue and the patch I attached to the bug ? I would like
a consensus around that change before I commit anything.
I'm ready to explain in greater detail, but given the hour I have to
prioritize.
Thanks!
Antoine
---------- Forwarded message ----------
From: Antoine Toulme (JIRA) <ji...@apache.org>
Date: Tue, Mar 16, 2010 at 23:16
Subject: [jira] Updated: (BUILDR-401) Don't set compiler to output warnings
if verbose
To: antoine@lunar-ocean.com
[
https://issues.apache.org/jira/browse/BUILDR-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
Antoine Toulme updated BUILDR-401:
----------------------------------
Attachment: BUILDR-401.patch
Here is a patch that allows for only enabling if they are set.
> Don't set compiler to output warnings if verbose
> ------------------------------------------------
>
> Key: BUILDR-401
> URL: https://issues.apache.org/jira/browse/BUILDR-401
> Project: Buildr
> Issue Type: Improvement
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
> Assignee: Antoine Toulme
> Fix For: 1.4
>
> Attachments: BUILDR-401.patch
>
>
> By default Buildr will output warnings if the verbose flag is set.
> The problem is that it is set very often.
> We should let people only get warnings if they mean it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (BUILDR-401) Don't set compiler to output
warnings if verbose
Posted by Antoine Toulme <an...@lunar-ocean.com>.
OK, here is more detail:
right now we decide whether warnings are enabled or not using the warnings
method on the compile task.
The default value for the warning is whether we want to be verbose or not.
To me, that's already a problem. I think choosing to expose warnings should
not be related to the verbose output, more to a choice of the user.
Mind you, most projects can live with it. If you use javac, its output is
sparse and warnings are not showing much.
If you use ecj, it's another story.
First off, ecj does a very good job at outputting warnings and errors. A
much better job imho than javac.
But that means more lines used per warning.
ecj is capable of expanding warnings to all java conformance levels. It
signals annotations, List<T> issues and the like.
The end result is that if you try to compile Hibernate for example, you get
8000 warnings.
The ecj compiler implementation depends on the javac one to be DRY.
Since the initialization of options[:warnings] is made in the constructor,
we end up being screwed there.
I'm open to other ways of achieving the desired result by moving the
initialization in a protected method. In fact, I'll work on a patch for
that.
Please let me know what you think.
Antoine
On Tue, Mar 16, 2010 at 23:19, Antoine Toulme <an...@lunar-ocean.com>wrote:
> Can we discuss this issue and the patch I attached to the bug ? I would
> like a consensus around that change before I commit anything.
>
> I'm ready to explain in greater detail, but given the hour I have to
> prioritize.
>
> Thanks!
>
> Antoine
>
>
> ---------- Forwarded message ----------
> From: Antoine Toulme (JIRA) <ji...@apache.org>
> Date: Tue, Mar 16, 2010 at 23:16
> Subject: [jira] Updated: (BUILDR-401) Don't set compiler to output warnings
> if verbose
> To: antoine@lunar-ocean.com
>
>
>
> [
> https://issues.apache.org/jira/browse/BUILDR-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Antoine Toulme updated BUILDR-401:
> ----------------------------------
>
> Attachment: BUILDR-401.patch
>
> Here is a patch that allows for only enabling if they are set.
>
> > Don't set compiler to output warnings if verbose
> > ------------------------------------------------
> >
> > Key: BUILDR-401
> > URL: https://issues.apache.org/jira/browse/BUILDR-401
> > Project: Buildr
> > Issue Type: Improvement
> > Affects Versions: 1.3.5
> > Reporter: Antoine Toulme
> > Assignee: Antoine Toulme
> > Fix For: 1.4
> >
> > Attachments: BUILDR-401.patch
> >
> >
> > By default Buildr will output warnings if the verbose flag is set.
> > The problem is that it is set very often.
> > We should let people only get warnings if they mean it.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
>