You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/23 11:43:52 UTC
[GitHub] [orc] stiga-huang opened a new pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
stiga-huang opened a new pull request #879:
URL: https://github.com/apache/orc/pull/879
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
Currently in the C++ reader, SearchArgumentBuilder only provides interfaces for creating SearchArguments using field column names. Column names can be ambiguous if there are nested struct columns using the same names. Array item column or map key/value columns even don't have names.
This patch addes corresponding interfaces to create SearchArguments using column ids. Refactors some codes using templates to avoid duplicated codes.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
As described above and in the JIRA description, we need creating SearchArguments using column ids.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added end-to-end tests in c++/test/TestPredicatePushdown.cc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #879:
URL: https://github.com/apache/orc/pull/879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #879:
URL: https://github.com/apache/orc/pull/879#issuecomment-904754094
BTW, the current release blocker is ORC-811 (LazyIO of non-filter columns benchmark) and Apache Iceberg Integration Testing.
- https://github.com/dongjoon-hyun/iceberg/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #879:
URL: https://github.com/apache/orc/pull/879#issuecomment-904294022
Thank you, @wgtmac .
According to the affected version of ORC-960, @stiga-huang seems to create ORC-960 for Apache ORC 1.7.0.
Although Apache ORC 1.7 has been in the feature freeze status, do you think we need to land this in branch-1.7?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #879:
URL: https://github.com/apache/orc/pull/879#issuecomment-904751843
Merged to main/branch-1.7 for Apache ORC 1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #879:
URL: https://github.com/apache/orc/pull/879#issuecomment-904211986
cc @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] stiga-huang commented on pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
Posted by GitBox <gi...@apache.org>.
stiga-huang commented on pull request #879:
URL: https://github.com/apache/orc/pull/879#issuecomment-904333663
Impala will wait for this feature. It'd be good if the coming ORC 1.7.0 release can have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #879:
URL: https://github.com/apache/orc/pull/879#issuecomment-904750692
Got it, @stiga-huang and @wgtmac .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #879: ORC-960: [C++] Support creating SearchArguments using column ids
Posted by GitBox <gi...@apache.org>.
wgtmac commented on pull request #879:
URL: https://github.com/apache/orc/pull/879#issuecomment-904381378
> Thank you, @wgtmac .
> According to the affected version of [ORC-960](https://issues.apache.org/jira/browse/ORC-960), @stiga-huang seems to create [ORC-960](https://issues.apache.org/jira/browse/ORC-960) for Apache ORC 1.7.0.
> Although Apache ORC 1.7 has been in the feature freeze status, do you think we need to land this in branch-1.7?
This change is limited to C++ only. I am OK if landing it into branch-1.7 will not delay the release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org