[GitHub] [flink] walterddr commented on a change in pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection …

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection …
URL: https://github.com/apache/flink/pull/6336#discussion_r358556562
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09PartitionDiscoverer.java
 ##########
 @@ -81,6 +82,9 @@ protected void initializeConnections() {
 		} catch (org.apache.kafka.common.errors.WakeupException e) {
 			// rethrow our own wakeup exception
 			throw new WakeupException();
+		} catch (TopicAuthorizationException tae) {
+			closeConnectionsQuietly();
 
 Review comment:
   
   ```suggestion
   			try {
   			  close();
   			} catch (Exception e) {
   			  throw new RuntimeException("Error while closing partition discoverer.", e);
   			}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services