[GitHub] [ignite] zstan commented on a change in pull request #7743: IGNITE-12938

[GitBox <gi...@apache.org>]

zstan commented on a change in pull request #7743:
URL: https://github.com/apache/ignite/pull/7743#discussion_r421464832



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/VerifyBackupPartitionsTaskV2.java
##########
@@ -252,97 +250,68 @@ public VerifyBackupPartitionsJobV2(VisorIdleVerifyTaskArg arg) {
 
         /** {@inheritDoc} */
         @Override public Map<PartitionKeyV2, PartitionHashRecordV2> execute() throws IgniteException {
+            try {
+                ignite.context().cache().context().database().waitForCheckpoint("VerifyBackupPartitions");
+            }
+            catch (IgniteCheckedException e) {
+                throw new IgniteException(
+                    "Failed to wait for checkpoint before executing verify backup partitions task", e);
+            }

Review comment:
       yep, due to async cluster wide cp, some pages can already synced to storage while others would be still in mem, thus further code : IdleVerifyUtility#checkPartitionsPageCrcSum would return different results. This additional cp prevent from this. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org