[GitHub] [maven-site-plugin] rfscholte commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425670278



##########
File path: Jenkinsfile
##########
@@ -17,4 +17,4 @@
  * under the License.
  */
 
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x', '3.2.x', '3.3.x', '3.5.x'])
+asfMavenTlpPlgnBuild(jdk:['8','11','12'], maven:['3.2.x', '3.3.x', '3.5.x'])

Review comment:
       let's not make a separate method. My preferred solution would be to specify `[8..maxJdk]`, where `maxJdk` is an available constant in the script, but Groovy started to support this in the recent Groovy 3, not sure if Jenkins is already using this. Another solution would be `minJdk:'8'`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org