You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/12/07 23:34:32 UTC
Re: Review Request 38253: Add containerId to ResourceUsage to enable
QoS controller to target a container
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38253/#review109207
-----------------------------------------------------------
include/mesos/mesos.proto (line 821)
<https://reviews.apache.org/r/38253/#comment168684>
We missed to update the V1 API with this change, it seems.
- Till Toenshoff
On Sept. 17, 2015, 5:41 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38253/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 5:41 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-2875
> https://issues.apache.org/jira/browse/MESOS-2875
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We should ensure that we are addressing the container which the QoS controller intended to kill. Without this check, we may run into a scenario where the executor has terminated and one with the same id has started in the interim i.e. running in a different container than the one the QoS controller targeted.
>
> This most likely requires us to add containerId to the ResourceUsage message and encode the containerID in the QoS Correction message.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 899d52f
> include/mesos/slave/oversubscription.proto fa69a95
> src/slave/slave.cpp 93353a1
> src/tests/oversubscription_tests.cpp 0c5edaf
>
> Diff: https://reviews.apache.org/r/38253/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 38253: Add containerId to ResourceUsage to enable
QoS controller to target a container
Posted by Klaus Ma <kl...@gmail.com>.
> On Dec. 8, 2015, 6:34 a.m., Till Toenshoff wrote:
> > include/mesos/mesos.proto, line 821
> > <https://reviews.apache.org/r/38253/diff/3/?file=1076086#file1076086line821>
> >
> > We missed to update the V1 API with this change, it seems.
Posted a new RR#41066 to address.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38253/#review109207
-----------------------------------------------------------
On Sept. 18, 2015, 1:41 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38253/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 1:41 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-2875
> https://issues.apache.org/jira/browse/MESOS-2875
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We should ensure that we are addressing the container which the QoS controller intended to kill. Without this check, we may run into a scenario where the executor has terminated and one with the same id has started in the interim i.e. running in a different container than the one the QoS controller targeted.
>
> This most likely requires us to add containerId to the ResourceUsage message and encode the containerID in the QoS Correction message.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 899d52f
> include/mesos/slave/oversubscription.proto fa69a95
> src/slave/slave.cpp 93353a1
> src/tests/oversubscription_tests.cpp 0c5edaf
>
> Diff: https://reviews.apache.org/r/38253/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>