You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by "RCQE-bot (via GitHub)" <gi...@apache.org> on 2024/04/16 11:17:38 UTC

Re: [PR] AMBARI-25478. Badly formatted request may cause Ambari to crash. [ambari]

RCQE-bot commented on PR #3179:
URL: https://github.com/apache/ambari/pull/3179#issuecomment-2058845966

   ## RCQE-bot: Commit Quality Assessment  🔎 
   I've carefully evaluated the recent commits, and here's the current state of the commit quality: 
   ### Metrics 📊  
   - Previous Commits: diff hunk in file [...i-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java](https://github.com/apache/ambari/pull/3179/files/5f6fb25b6c1c54368702c106baea93314509015a#diff-384f562a6ccf3dd83b1fe9fa27405d36844d2c792c2c9446917723a4b53310c6) in commit [ae3cb1d3cde73cbd61e5c71d1fbdde4a53997a8b](https://github.com/apache/ambari/pull/3179/commits/ae3cb1d3cde73cbd61e5c71d1fbdde4a53997a8b)
   - Code Review: @dvitiiuk nah, please add "start < end" check here as well
   ### Suggestions 💡 
   - Need Review Again 🚫 : The commits do not currently meet the quality standards. I recommend not merging them into the main branch until the above suggestions have been implemented and a subsequent review confirms the quality. Please address the points mentioned and submit the commits for another round of review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org