[GitHub] [tvm-vta] zhanghaohit commented on pull request #9: [Hardware][OpenCL] Intelfocl support

[GitBox <gi...@apache.org>]

zhanghaohit commented on pull request #9:
URL: https://github.com/apache/tvm-vta/pull/9#issuecomment-741526316


   > @zhanghaohit what I'd like to suggest is that we temporarily disable the unit tests that are failing and re-enable them once we've update TVM since there's a bit of a circular dependence to make the tests work
   > 
   > Please comment out the test in `tests/scripts/docker_bash.sh` here `./tests/scripts/task_python_vta_tsim.sh`. I'll take care of enabling the TSIM test once we have that merged into TVM.
   
   Thanks @tmoreau89 for the suggestion. 
   
   I cannot find the test `./tests/scripts/task_python_vta_tsim.sh` in `tests/scripts/docker_bash.sh`. So I add a condition check to skip this test [here:](https://github.com/apache/tvm-vta/blob/48fb34e4d76c22a4fd7c5dfbbcf3dc50b0568e59/tests/scripts/docker_bash.sh#L70). I also tried to comment out the test in [Jenkinsfile](https://github.com/apache/tvm-vta/blob/48fb34e4d76c22a4fd7c5dfbbcf3dc50b0568e59/Jenkinsfile#L87), but it seems not working. 
   
   Now the CI has passed. Could you help check? And thanks for the help to re-enable the tsim test after all are merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org