You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/31 17:06:20 UTC

[GitHub] jvrao opened a new pull request #1091: BOOKKEEPER-1063:Write keeps refCnt longer

jvrao opened a new pull request #1091: BOOKKEEPER-1063:Write keeps refCnt longer
URL: https://github.com/apache/bookkeeper/pull/1091
 
 
   Current code keeps the toSend buffers until client receives
   resonses from all wq bookies. From the senders perspective,
   It is not required to keep the refcount on it at the PendingAddOp
   level, as the ref is taken at bookie client level.
   
   Keeping these buffers longer will increase the memory pressure
   on the client.
   
   Signed-off-by: Venkateswararao Jujjuri (JV) <vj...@salesforce.com>
   
   Descriptions of the changes in this PR:
   
   (PR description content here)...
   
   Master Issue: #<master-issue-number>
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue # or BOOKKEEPER-#>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   >     `e.g. BOOKKEEPER-1234: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services