You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Cott (JIRA)" <ji...@apache.org> on 2006/06/01 18:50:29 UTC

[jira] Created: (VALIDATOR-190) EmailValidator allows control characters (ASCII 0-31)

EmailValidator allows control characters (ASCII 0-31)
-----------------------------------------------------

         Key: VALIDATOR-190
         URL: http://issues.apache.org/jira/browse/VALIDATOR-190
     Project: Commons Validator
        Type: Bug

    Versions: 1.3.0 Release    
    Reporter: Cott
    Priority: Minor


EmailValidator allows ASCII 0 - 31 in an email address.

According to RFC 821, these are forbidden.

import org.apache.commons.validator.EmailValidator;

public class Test {

  public static void main(String[] args) {
    EmailValidator ev = EmailValidator.getInstance();

    String email ="\000nobody@nowhere.com";
    System.err.println(ev.isValid(email));

  }

}


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Resolved: (VALIDATOR-190) EmailValidator allows control characters (ASCII 0-31)

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-190?page=all ]

Niall Pemberton resolved VALIDATOR-190.
---------------------------------------

    Fix Version/s: 1.3.1
       Resolution: Fixed
         Assignee: Niall Pemberton

I applied a slightly different change since any valid ASCII character is allowed if its quoted - so I changed the excluded "special characters" which are used to define atom/word to also exclude ascii control characters (ASCII 0-31 and 127).

   http://svn.apache.org/viewvc?view=rev&revision=478560

You can test out the changes using the next nightly build:
   http://people.apache.org/builds/jakarta-commons/nightly/commons-validator/

Thanks for reporting this and your help!

Niall

> EmailValidator allows control characters (ASCII 0-31)
> -----------------------------------------------------
>
>                 Key: VALIDATOR-190
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-190
>             Project: Commons Validator
>          Issue Type: Bug
>          Components: Routines
>    Affects Versions: 1.3.0 Release
>            Reporter: Cott
>         Assigned To: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.3.1
>
>         Attachments: EmailTest-diff.txt, EmailValidator-diff.txt
>
>
> EmailValidator allows ASCII 0 - 31 in an email address.
> According to RFC 821, these are forbidden.
> import org.apache.commons.validator.EmailValidator;
> public class Test {
>   public static void main(String[] args) {
>     EmailValidator ev = EmailValidator.getInstance();
>     String email ="\000nobody@nowhere.com";
>     System.err.println(ev.isValid(email));
>   }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VALIDATOR-190) EmailValidator allows control characters (ASCII 0-31)

Posted by "Gabriel Belingueres (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/VALIDATOR-190?page=comments#action_12414623 ] 

Gabriel Belingueres commented on VALIDATOR-190:
-----------------------------------------------

Hi Cott,

I found this other link on the net that may be helpful. Apparently, there are some more chars that should be forbidden/discouraged to use in the local part of the email address.

It may be worth take a look at it: http://www.remote.org/jochen/mail/info/chars.html

Gabriel


> EmailValidator allows control characters (ASCII 0-31)
> -----------------------------------------------------
>
>          Key: VALIDATOR-190
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-190
>      Project: Commons Validator
>         Type: Bug

>     Versions: 1.3.0 Release
>     Reporter: Cott
>     Priority: Minor

>
> EmailValidator allows ASCII 0 - 31 in an email address.
> According to RFC 821, these are forbidden.
> import org.apache.commons.validator.EmailValidator;
> public class Test {
>   public static void main(String[] args) {
>     EmailValidator ev = EmailValidator.getInstance();
>     String email ="\000nobody@nowhere.com";
>     System.err.println(ev.isValid(email));
>   }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VALIDATOR-190) EmailValidator allows control characters (ASCII 0-31)

Posted by "Cott (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/VALIDATOR-190?page=comments#action_12414353 ] 

Cott commented on VALIDATOR-190:
--------------------------------

I read RFC 2821 and RFC 2822 as also forbidding control characters in email addresses as well. Maybe I'm just delusional after an exceptionally long week? :)





> EmailValidator allows control characters (ASCII 0-31)
> -----------------------------------------------------
>
>          Key: VALIDATOR-190
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-190
>      Project: Commons Validator
>         Type: Bug

>     Versions: 1.3.0 Release
>     Reporter: Cott
>     Priority: Minor

>
> EmailValidator allows ASCII 0 - 31 in an email address.
> According to RFC 821, these are forbidden.
> import org.apache.commons.validator.EmailValidator;
> public class Test {
>   public static void main(String[] args) {
>     EmailValidator ev = EmailValidator.getInstance();
>     String email ="\000nobody@nowhere.com";
>     System.err.println(ev.isValid(email));
>   }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-190) EmailValidator allows control characters (ASCII 0-31)

Posted by "Gabriel Belingueres (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-190?page=all ]

Gabriel Belingueres updated VALIDATOR-190:
------------------------------------------

    Attachment: EmailValidator-diff.txt
                EmailTest-diff.txt

Hi,

I'm uploading the patch files that would solve the issue (ie not allowing ASCII 0..31 in the local part of the email address), along with a test case.

Gabriel


> EmailValidator allows control characters (ASCII 0-31)
> -----------------------------------------------------
>
>          Key: VALIDATOR-190
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-190
>      Project: Commons Validator
>         Type: Bug

>     Versions: 1.3.0 Release
>     Reporter: Cott
>     Priority: Minor
>  Attachments: EmailTest-diff.txt, EmailValidator-diff.txt
>
> EmailValidator allows ASCII 0 - 31 in an email address.
> According to RFC 821, these are forbidden.
> import org.apache.commons.validator.EmailValidator;
> public class Test {
>   public static void main(String[] args) {
>     EmailValidator ev = EmailValidator.getInstance();
>     String email ="\000nobody@nowhere.com";
>     System.err.println(ev.isValid(email));
>   }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VALIDATOR-190) EmailValidator allows control characters (ASCII 0-31)

Posted by "Gabriel Belingueres (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/VALIDATOR-190?page=comments#action_12414348 ] 

Gabriel Belingueres commented on VALIDATOR-190:
-----------------------------------------------

Hi,

RFC 821 is obsoleted by RFC 2821
.
I found this one on the net what may be worth looking: RFC 2822 (Internet Message format) and RFC 2234 (Augmented BNF).

However it may well be a lot easier to post a question on the Apache Web server list.

Gabriel

> EmailValidator allows control characters (ASCII 0-31)
> -----------------------------------------------------
>
>          Key: VALIDATOR-190
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-190
>      Project: Commons Validator
>         Type: Bug

>     Versions: 1.3.0 Release
>     Reporter: Cott
>     Priority: Minor

>
> EmailValidator allows ASCII 0 - 31 in an email address.
> According to RFC 821, these are forbidden.
> import org.apache.commons.validator.EmailValidator;
> public class Test {
>   public static void main(String[] args) {
>     EmailValidator ev = EmailValidator.getInstance();
>     String email ="\000nobody@nowhere.com";
>     System.err.println(ev.isValid(email));
>   }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-190) EmailValidator allows control characters (ASCII 0-31)

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-190?page=all ]

Niall Pemberton updated VALIDATOR-190:
--------------------------------------

    Component/s: Routines

> EmailValidator allows control characters (ASCII 0-31)
> -----------------------------------------------------
>
>                 Key: VALIDATOR-190
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-190
>             Project: Commons Validator
>          Issue Type: Bug
>          Components: Routines
>    Affects Versions: 1.3.0 Release
>            Reporter: Cott
>            Priority: Minor
>         Attachments: EmailTest-diff.txt, EmailValidator-diff.txt
>
>
> EmailValidator allows ASCII 0 - 31 in an email address.
> According to RFC 821, these are forbidden.
> import org.apache.commons.validator.EmailValidator;
> public class Test {
>   public static void main(String[] args) {
>     EmailValidator ev = EmailValidator.getInstance();
>     String email ="\000nobody@nowhere.com";
>     System.err.println(ev.isValid(email));
>   }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org