You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/08 15:40:15 UTC

[GitHub] jaylindquist opened a new pull request #6618: Support preselect_filters without filter_box IDs

jaylindquist opened a new pull request #6618: Support preselect_filters without filter_box IDs
URL: https://github.com/apache/incubator-superset/pull/6618
 
 
   We have a use case where external applications build links to dashboards with filters. Currently that requires these applications to know internal database IDs for filter boxes in order to build the `preselect_filters` query parameter.
   
   A second use case we have is users saving links to dashboards with `preselect_filters` already applied with the filter box ID.
   
   > `.../superset/dashboard/dash/?preselect_filters={"414":{"column":["value"]}}`
   
   When moving between environments or during normal maintenance, the filter box IDs may change causing external applications to update and breaking saved links.
   
   This change supports `preselect_filters` without filter box IDs allowing:
   * External applications generating filters for dashboards without needing database IDs
   * "Share Dashboard" button generating share links without dashboard filters, letting them continue to work if filter box IDs change
   * Backwards compatibility of `preselect_filters` allowing existing saved links to function
   
   > `.../superset/dashboard/dash/?preselect_filters={"column":["value"]}`
   
   When a dashboard is loaded with the above `preselect_filters` the `getInitialState()` function for dashboards will search through all filter boxes that support `column` as a filter and set it to `["value"]` as its value. Additionally, `preselect_filters` is backwards compatible, supporting the original format as well as the new format.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org