You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by TILL TOENSHOFF <to...@me.com> on 2014/02/21 19:27:42 UTC

Review Request 18360: Include std::tuple or boost::tuples::tuple within the process::tuples namespace.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/
-----------------------------------------------------------

Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.


Bugs: MESOS-1026
    https://issues.apache.org/jira/browse/MESOS-1026


Repository: mesos-git


Description
-------

Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of the process::tuples namespace.

Example usage including fully qualified namespaces:

process::tuples::tuple<int, bool> tuple = process:tuples::make_tuple(42, true);
int foo = process::tuples::get<0>(tuple);

Additionally, some omissions within Makefile.am have been fixed that left out the C++11 specific headers as well as the existing tuples/tuples.hpp and tuples/details.hpp.


Diffs
-----

  3rdparty/libprocess/Makefile.am a7d199f 
  3rdparty/libprocess/include/process/tuples/tuple.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/18360/diff/


Testing
-------

make check (clang c++11, gcc), functional testing


Thanks,

TILL TOENSHOFF


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Niklas Nielsen <ni...@qni.dk>.

> On Feb. 27, 2014, 10:34 a.m., Dominic Hamon wrote:
> > Ship It!

Cool - I'll go ahead and commit this if there are no other comments.


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review35661
-----------------------------------------------------------


On Feb. 24, 2014, 10:48 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 10:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review35661
-----------------------------------------------------------

Ship it!


Ship It!

- Dominic Hamon


On Feb. 24, 2014, 10:48 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 10:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Till Toenshoff <to...@me.com>.

> On March 5, 2014, 10:51 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp, line 20
> > <https://reviews.apache.org/r/18360/diff/3/?file=502379#file502379line20>
> >
> >     Question: why not include <tr1/tuple> when C++11 is not available?
> >     
> >     This is what the other headers do:
> >     
> >     lambda.hpp
> >     memory.hpp
> >     
> >     I can't tell from the discussion on this review, was there a reason to do it differently for tuple?

Because we are relying on boost-tuple in other places already (3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp, 3rdparty/libprocess/include/process/tuples/tuples.hpp) and I wanted to stay in line with those instead of dragging in another variant.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review36278
-----------------------------------------------------------


On Feb. 24, 2014, 6:48 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 6:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Ben Mahler <be...@gmail.com>.

> On March 5, 2014, 10:51 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp, line 20
> > <https://reviews.apache.org/r/18360/diff/3/?file=502379#file502379line20>
> >
> >     Question: why not include <tr1/tuple> when C++11 is not available?
> >     
> >     This is what the other headers do:
> >     
> >     lambda.hpp
> >     memory.hpp
> >     
> >     I can't tell from the discussion on this review, was there a reason to do it differently for tuple?
> 
> Till Toenshoff wrote:
>     Because we are relying on boost-tuple in other places already (3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp, 3rdparty/libprocess/include/process/tuples/tuples.hpp) and I wanted to stay in line with those instead of dragging in another variant.

It's still not clear to me that we should be using boost's tuple instead of tr1's tuple:

1. That process/tuples folder looks like dead code, and is only used by httpd.cpp and test-master.cpp. These also appear dead, do they even compile?

2. Does foreach.hpp need tuple.hpp to compile? It doesn't appear so at first glance so we should add a comment. If so, will you be updating foreach.hpp to include stout/tuple.hpp rather than doing a custom boost include?

3. Will you be updating src/zookeeper/zookeeper.cpp to not directly include from boost now that we have this?

The motivation for tr1 is so that we consistently fall back to tr1 headers when we don't have C++11.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review36278
-----------------------------------------------------------


On Feb. 24, 2014, 6:48 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 6:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Till Toenshoff <to...@me.com>.

> On March 5, 2014, 10:51 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp, line 20
> > <https://reviews.apache.org/r/18360/diff/3/?file=502379#file502379line20>
> >
> >     Question: why not include <tr1/tuple> when C++11 is not available?
> >     
> >     This is what the other headers do:
> >     
> >     lambda.hpp
> >     memory.hpp
> >     
> >     I can't tell from the discussion on this review, was there a reason to do it differently for tuple?
> 
> Till Toenshoff wrote:
>     Because we are relying on boost-tuple in other places already (3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp, 3rdparty/libprocess/include/process/tuples/tuples.hpp) and I wanted to stay in line with those instead of dragging in another variant.
> 
> Ben Mahler wrote:
>     It's still not clear to me that we should be using boost's tuple instead of tr1's tuple:
>     
>     1. That process/tuples folder looks like dead code, and is only used by httpd.cpp and test-master.cpp. These also appear dead, do they even compile?
>     
>     2. Does foreach.hpp need tuple.hpp to compile? It doesn't appear so at first glance so we should add a comment. If so, will you be updating foreach.hpp to include stout/tuple.hpp rather than doing a custom boost include?
>     
>     3. Will you be updating src/zookeeper/zookeeper.cpp to not directly include from boost now that we have this?
>     
>     The motivation for tr1 is so that we consistently fall back to tr1 headers when we don't have C++11.

Yes, you are right, tr1/tuple can be used and for keeping things consistent as you drafted, is used in my upcoming, latest revision of this patch.

re 1. That code could indeed be removed then from a mesos point of view.
re 2. Nope, not needed. Will add another RR that removes that include.
re 3. Yes, yet another RR upcoming :)

Thanks for looking into this, it makes more sense this way.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review36278
-----------------------------------------------------------


On Feb. 24, 2014, 6:48 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 6:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review36278
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp
<https://reviews.apache.org/r/18360/#comment67240>

    Question: why not include <tr1/tuple> when C++11 is not available?
    
    This is what the other headers do:
    
    lambda.hpp
    memory.hpp
    
    I can't tell from the discussion on this review, was there a reason to do it differently for tuple?


- Ben Mahler


On Feb. 24, 2014, 6:48 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 6:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Niklas Nielsen <ni...@qni.dk>.

> On Feb. 24, 2014, 11:13 a.m., Niklas Nielsen wrote:
> > Ship It!

ping - could someone take a quick view on this RR?


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review35315
-----------------------------------------------------------


On Feb. 24, 2014, 10:48 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 10:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review35315
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Feb. 24, 2014, 10:48 a.m., TILL TOENSHOFF wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 10:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> TILL TOENSHOFF
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by TILL TOENSHOFF <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 6:48 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.


Changes
-------

Added include guard and license note.


Bugs: MESOS-1026
    https://issues.apache.org/jira/browse/MESOS-1026


Repository: mesos-git


Description
-------

Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.

Example usage including fully qualified namespaces:

#include <stout/tuple.hpp>
tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
int foo = tuples::get<0>(tuple);


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
  3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/18360/diff/


Testing
-------

make check (clang c++11, gcc), functional testing


Thanks,

TILL TOENSHOFF


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review35244
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp
<https://reviews.apache.org/r/18360/#comment65697>

    Are we missing a license block here? :)


- Niklas Nielsen


On Feb. 21, 2014, 3:28 p.m., TILL TOENSHOFF wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 3:28 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> TILL TOENSHOFF
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review35212
-----------------------------------------------------------

Ship it!


Ship It!

- Adam B


On Feb. 21, 2014, 3:28 p.m., TILL TOENSHOFF wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 3:28 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> TILL TOENSHOFF
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/#review35309
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp
<https://reviews.apache.org/r/18360/#comment65775>

    In addition to the license block, we need an include guard.


- Benjamin Hindman


On Feb. 21, 2014, 11:28 p.m., TILL TOENSHOFF wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18360/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 11:28 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1026
>     https://issues.apache.org/jira/browse/MESOS-1026
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.
> 
> Example usage including fully qualified namespaces:
> 
> #include <stout/tuple.hpp>
> tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
> int foo = tuples::get<0>(tuple);
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18360/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc), functional testing
> 
> 
> Thanks,
> 
> TILL TOENSHOFF
> 
>


Re: Review Request 18360: Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.

Posted by TILL TOENSHOFF <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18360/
-----------------------------------------------------------

(Updated Feb. 21, 2014, 11:28 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.


Changes
-------

Moved to stout.


Summary (updated)
-----------------

Include std::tuple or boost::tuples::tuple within a tuples namespace of stout.


Bugs: MESOS-1026
    https://issues.apache.org/jira/browse/MESOS-1026


Repository: mesos-git


Description (updated)
-------

Namespace pull-in of std::tuple or boost::tuples::tuple, depending on the availability of C+11. The results are part of a tuples namespace of stout.

Example usage including fully qualified namespaces:

#include <stout/tuple.hpp>
tuples::tuple<int, bool> tuple = tuples::make_tuple(42, true);
int foo = tuples::get<0>(tuple);


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 
  3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/18360/diff/


Testing
-------

make check (clang c++11, gcc), functional testing


Thanks,

TILL TOENSHOFF