You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jeremy Thomerson (JIRA)" <ji...@apache.org> on 2008/11/04 22:10:44 UTC

[jira] Issue Comment Edited: (WICKET-1883) Refactor some constants in WebRequestCodingStrategy

    [ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645077#action_12645077 ] 

jthomerson edited comment on WICKET-1883 at 11/4/08 1:08 PM:
-------------------------------------------------------------------

We could give this a try.  It adds a setting in IMarkupSettings that lets you configure the name space to use for URLs.  It only covers the namespace - not the other terms.  If you wanted to be able to override all of those, you would probably need another I*Settings interface.

      was (Author: jthomerson):
    We could give this a try.  It adds a setting in IMarkupSettings that lets you configure the name space to use for URLs.
  
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
>                 Key: WICKET-1883
>                 URL: https://issues.apache.org/jira/browse/WICKET-1883
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket
>            Reporter: Kirill Balyasnikov
>            Priority: Trivial
>         Attachments: 1883.patch
>
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.