[GitHub] [arrow] emkornfield commented on a change in pull request #11131: ARROW-13965: [C++] dynamic_casts in parquet TypedColumnWriterImpl impacting performance

[GitBox <gi...@apache.org>]

emkornfield commented on a change in pull request #11131:
URL: https://github.com/apache/arrow/pull/11131#discussion_r706906066



##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1358,6 +1363,8 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<
       // Only PLAIN encoding is supported for fallback in V1
       current_encoder_ = MakeEncoder(DType::type_num, Encoding::PLAIN, false, descr_,
                                      properties_->memory_pool());
+      current_value_encoder_ = dynamic_cast<ValueEncoderType*>(current_encoder_.get());
+      current_dict_encoder_ = 0;  // not using dict

Review comment:
       ```suggestion
         current_dict_encoder_ = nullptr;  // not using dict
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org