You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jiale Tan (Jira)" <ji...@apache.org> on 2022/11/04 06:17:00 UTC
[jira] [Comment Edited] (FLINK-29610) Infinite timeout is used in SavepointHandlers and CheckpointTriggerHandler calls to RestfulGateway
[ https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628690#comment-17628690 ]
Jiale Tan edited comment on FLINK-29610 at 11/4/22 6:16 AM:
------------------------------------------------------------
[~gaoyunhaii] thanks for the info!
I created a PR [https://github.com/apache/flink/pull/21239] as per my understanding, it would be nice if you may take a look. [~gaoyunhaii] [~chesnay]
Meanwhile I am tracking how this Timeout will be used all the way till [here|https://github.com/apache/flink/blob/e9f3ec93aad7cec795c765c937ee71807f5478cf/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java#L856-L879]. And it seems all those timeout are not being used later?
FYI [~thomasWeise] this is part of unfinished work from FLINK-27101
was (Author: JIRAUSER290356):
[~gaoyunhaii] thanks for the info!
I created a PR [https://github.com/apache/flink/pull/21239] as per my understanding, it would be nice if you may take a look. [~gaoyunhaii] [~chesnay]
Meanwhile I am tracking how this Timeout will be used all the way till [here|https://github.com/apache/flink/blob/e9f3ec93aad7cec795c765c937ee71807f5478cf/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java#L856-L879]. And it seems all those timeout are not being used?
FYI [~thomasWeise] this is part of unfinished work from FLINK-27101
> Infinite timeout is used in SavepointHandlers and CheckpointTriggerHandler calls to RestfulGateway
> --------------------------------------------------------------------------------------------------
>
> Key: FLINK-29610
> URL: https://issues.apache.org/jira/browse/FLINK-29610
> Project: Flink
> Issue Type: Bug
> Components: Runtime / REST
> Reporter: Jiale Tan
> Assignee: Jiale Tan
> Priority: Major
> Labels: pull-request-available
>
> In {{{}SavepointHandlers{}}}, both {{[StopWithSavepointHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L214]}} and {{[SavepointTriggerHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L258]}} are calling {{RestfulGateway}} with {{RpcUtils.INF_TIMEOUT}}
> Same thing happens in the {{[CheckpointTriggerHandler|https://github.com/apache/flink/blob/8e66be89dfcb54b7256d51e9d89222ae6701061f/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/checkpoints/CheckpointHandlers.java#L146]}}
> As pointed out in [this|https://github.com/apache/flink/pull/20852#discussion_r992218970] discussion, we will need to either figure out why {{RpcUtils.INF_TIMEOUT}} is used, or remove it if there is no strong reason to use it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)