[GitHub] [maven-resolver] michael-o commented on a change in pull request #112: Mresolver 152

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #112:
URL: https://github.com/apache/maven-resolver/pull/112#discussion_r654897946



##########
File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
##########
@@ -841,6 +843,7 @@ public RemoteRepository getMirror( RemoteRepository repository )
 
         public Authentication getAuthentication( RemoteRepository repository )
         {
+            requireNonNull( repository, "repository cannot be null" );

Review comment:
       I believe that this is a bug, it should return null, you change is correct though.

##########
File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
##########
@@ -815,6 +815,7 @@ private void failIfReadOnly()
 
         public Proxy getProxy( RemoteRepository repository )
         {
+            requireNonNull( repository, "repository cannot be null" );
             return repository.getProxy();

Review comment:
       I believe that this is a bug, it should return null, you change is correct though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org