You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/05/18 17:10:45 UTC
[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #3016: HADOOP-17699. Remove hardcoded SunX509 usage from SSLFactory.
xiaoyuyao commented on a change in pull request #3016:
URL: https://github.com/apache/hadoop/pull/3016#discussion_r634593315
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
##########
@@ -99,7 +101,13 @@
public static final String SSL_SERVER_EXCLUDE_CIPHER_LIST =
"ssl.server.exclude.cipher.list";
- public static final String SSLCERTIFICATE = IBM_JAVA?"ibmX509":"SunX509";
+ public static final String KEY_MANAGER_SSLCERTIFICATE =
Review comment:
Yes. That's my understanding too. We will have to add checkstyle exceptions if we want to keep the unused constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org