You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/21 19:15:14 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #7603: (WIP) Gihub CI EXP

merlimat commented on a change in pull request #7603:
URL: https://github.com/apache/pulsar/pull/7603#discussion_r458329477



##########
File path: .github/workflows/ci-license.yaml
##########
@@ -40,27 +42,7 @@ jobs:
           fetch-depth: 0
           ref: ${{ github.event.pull_request.head.sha }}
 
-      - name: Cache local Maven repository
-        uses: actions/cache@v2
-        with:
-          path: ~/.m2/repository
-          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
-          restore-keys: |
-            ${{ runner.os }}-maven-
-
-      - name: Set up JDK 1.8
-        uses: actions/setup-java@v1
-        with:
-          java-version: 1.8
-
-      # license check fails with 3.6.2 so we have to downgrade
-      - name: Set up Maven
-        uses: apache/pulsar-test-infra/setup-maven@master
-        with:
-          maven-version: 3.6.1
-
-      - name: build and check license
-        run: mvn -B -ntp -DskipTests license:check install
-          
       - name: license check
-        run: src/check-binary-license ./distribution/server/target/apache-pulsar-*-bin.tar.gz
+        run: |
+          mvn -B -ntp license:check install -DskipTests

Review comment:
       -Pcore-modules




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org