You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Willy Solaligue <wi...@lucidworks.com> on 2017/02/09 18:26:07 UTC
Re: Review Request 56508: Solr grafana dashboards - trunk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 6:26 p.m.)
Review request for Ambari and Vivek Ratnavel Subramanian.
Summary (updated)
-----------------
Solr grafana dashboards - trunk
Repository: ambari
Description
-------
- Grafana dashboards for the solr stack
- Solr stack available here: https://github.com/lucidworks/solr-stack
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
Diff: https://reviews.apache.org/r/56508/diff/
Testing
-------
Thanks,
Willy Solaligue
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/#review165037
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Feb. 9, 2017, 9:33 p.m., Willy Solaligue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56508/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 9:33 p.m.)
>
>
> Review request for Ambari and Vivek Ratnavel Subramanian.
>
>
> Bugs: AMBARI-19928
> https://issues.apache.org/jira/browse/AMBARI-19928
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Grafana dashboards for the solr stack
> - Solr stack available here: https://github.com/lucidworks/solr-stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
>
> Diff: https://reviews.apache.org/r/56508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Willy Solaligue
>
>
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Willy Solaligue <wi...@lucidworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 9:33 p.m.)
Review request for Ambari and Vivek Ratnavel Subramanian.
Bugs: AMBARI-19928
https://issues.apache.org/jira/browse/AMBARI-19928
Repository: ambari
Description
-------
- Grafana dashboards for the solr stack
- Solr stack available here: https://github.com/lucidworks/solr-stack
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
Diff: https://reviews.apache.org/r/56508/diff/
Testing
-------
Thanks,
Willy Solaligue
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Willy Solaligue <wi...@lucidworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 8:26 p.m.)
Review request for Ambari and Vivek Ratnavel Subramanian.
Bugs: AMBARI-19928
https://issues.apache.org/jira/browse/AMBARI-19928
Repository: ambari
Description
-------
- Grafana dashboards for the solr stack
- Solr stack available here: https://github.com/lucidworks/solr-stack
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
Diff: https://reviews.apache.org/r/56508/diff/
Testing
-------
Thanks,
Willy Solaligue
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Yusaku Sako <yu...@hortonworks.com>.
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing this out.
>
> Yusaku Sako wrote:
> Willy, this is outside the scope of this patch, but where can I log issues against the Solr mpack? I got an error regarding not being able to find java during Solr install.
I was not able to deploy Solr due to install issues. However, I did verify that the Solr dashboards get deployed automatically. One minor change that I suggest is to say "Solr - Cores" and "Solr - Hosts" rather than "Solr Cores Dashboard" and "Solr Hosts Dashboard" as the dashboard names to be consistent with the naming scheme of all other existing dashboards.
- Yusaku
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/#review164963
-----------------------------------------------------------
On Feb. 9, 2017, 6:38 p.m., Willy Solaligue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56508/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 6:38 p.m.)
>
>
> Review request for Ambari and Vivek Ratnavel Subramanian.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Grafana dashboards for the solr stack
> - Solr stack available here: https://github.com/lucidworks/solr-stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
>
> Diff: https://reviews.apache.org/r/56508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Willy Solaligue
>
>
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Yusaku Sako <yu...@hortonworks.com>.
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing this out.
>
> Yusaku Sako wrote:
> Willy, this is outside the scope of this patch, but where can I log issues against the Solr mpack? I got an error regarding not being able to find java during Solr install.
>
> Yusaku Sako wrote:
> I was not able to deploy Solr due to install issues. However, I did verify that the Solr dashboards get deployed automatically. One minor change that I suggest is to say "Solr - Cores" and "Solr - Hosts" rather than "Solr Cores Dashboard" and "Solr Hosts Dashboard" as the dashboard names to be consistent with the naming scheme of all other existing dashboards.
Also, please edit the "Bugs" field of this ReviewBoard to be AMBARI-19928. This creates a link back to the JIRA.
- Yusaku
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/#review164963
-----------------------------------------------------------
On Feb. 9, 2017, 6:38 p.m., Willy Solaligue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56508/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 6:38 p.m.)
>
>
> Review request for Ambari and Vivek Ratnavel Subramanian.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Grafana dashboards for the solr stack
> - Solr stack available here: https://github.com/lucidworks/solr-stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
>
> Diff: https://reviews.apache.org/r/56508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Willy Solaligue
>
>
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Willy Solaligue <wi...@lucidworks.com>.
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing this out.
>
> Yusaku Sako wrote:
> Willy, this is outside the scope of this patch, but where can I log issues against the Solr mpack? I got an error regarding not being able to find java during Solr install.
>
> Yusaku Sako wrote:
> I was not able to deploy Solr due to install issues. However, I did verify that the Solr dashboards get deployed automatically. One minor change that I suggest is to say "Solr - Cores" and "Solr - Hosts" rather than "Solr Cores Dashboard" and "Solr Hosts Dashboard" as the dashboard names to be consistent with the naming scheme of all other existing dashboards.
>
> Yusaku Sako wrote:
> Also, please edit the "Bugs" field of this ReviewBoard to be AMBARI-19928. This creates a link back to the JIRA.
>
> Yusaku Sako wrote:
> Here's a screenshot showing the naming scheme of dashboards: https://issues.apache.org/jira/secure/attachment/12851939/Screen%20Shot%202017-02-09%20at%2011.40.00%20AM.png
Yusaku,
- I just updated the diff file with the fixes that you suggested, please let me know if additional changes are required
- To log issues against the solr stack repo, please use the github issue tracker, this is the URL https://github.com/lucidworks/solr-stack/issues
- Ambari jira ID was added to the bugs field
- Willy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/#review164963
-----------------------------------------------------------
On Feb. 9, 2017, 9:33 p.m., Willy Solaligue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56508/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 9:33 p.m.)
>
>
> Review request for Ambari and Vivek Ratnavel Subramanian.
>
>
> Bugs: AMBARI-19928
> https://issues.apache.org/jira/browse/AMBARI-19928
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Grafana dashboards for the solr stack
> - Solr stack available here: https://github.com/lucidworks/solr-stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
>
> Diff: https://reviews.apache.org/r/56508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Willy Solaligue
>
>
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Yusaku Sako <yu...@hortonworks.com>.
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing this out.
>
> Yusaku Sako wrote:
> Willy, this is outside the scope of this patch, but where can I log issues against the Solr mpack? I got an error regarding not being able to find java during Solr install.
>
> Yusaku Sako wrote:
> I was not able to deploy Solr due to install issues. However, I did verify that the Solr dashboards get deployed automatically. One minor change that I suggest is to say "Solr - Cores" and "Solr - Hosts" rather than "Solr Cores Dashboard" and "Solr Hosts Dashboard" as the dashboard names to be consistent with the naming scheme of all other existing dashboards.
>
> Yusaku Sako wrote:
> Also, please edit the "Bugs" field of this ReviewBoard to be AMBARI-19928. This creates a link back to the JIRA.
Here's a screenshot showing the naming scheme of dashboards: https://issues.apache.org/jira/secure/attachment/12851939/Screen%20Shot%202017-02-09%20at%2011.40.00%20AM.png
- Yusaku
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/#review164963
-----------------------------------------------------------
On Feb. 9, 2017, 8:26 p.m., Willy Solaligue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56508/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 8:26 p.m.)
>
>
> Review request for Ambari and Vivek Ratnavel Subramanian.
>
>
> Bugs: AMBARI-19928
> https://issues.apache.org/jira/browse/AMBARI-19928
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Grafana dashboards for the solr stack
> - Solr stack available here: https://github.com/lucidworks/solr-stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
>
> Diff: https://reviews.apache.org/r/56508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Willy Solaligue
>
>
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Yusaku Sako <yu...@hortonworks.com>.
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing this out.
Willy, this is outside the scope of this patch, but where can I log issues against the Solr mpack? I got an error regarding not being able to find java during Solr install.
- Yusaku
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/#review164963
-----------------------------------------------------------
On Feb. 9, 2017, 6:38 p.m., Willy Solaligue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56508/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 6:38 p.m.)
>
>
> Review request for Ambari and Vivek Ratnavel Subramanian.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Grafana dashboards for the solr stack
> - Solr stack available here: https://github.com/lucidworks/solr-stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
>
> Diff: https://reviews.apache.org/r/56508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Willy Solaligue
>
>
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/#review164963
-----------------------------------------------------------
Thanks for this contribution and creating this ReviewBoard. I am testing this out.
- Yusaku Sako
On Feb. 9, 2017, 6:38 p.m., Willy Solaligue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56508/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 6:38 p.m.)
>
>
> Review request for Ambari and Vivek Ratnavel Subramanian.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Grafana dashboards for the solr stack
> - Solr stack available here: https://github.com/lucidworks/solr-stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
>
> Diff: https://reviews.apache.org/r/56508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Willy Solaligue
>
>
Re: Review Request 56508: Solr grafana dashboards - trunk
Posted by Willy Solaligue <wi...@lucidworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 6:38 p.m.)
Review request for Ambari and Vivek Ratnavel Subramanian.
Repository: ambari
Description
-------
- Grafana dashboards for the solr stack
- Solr stack available here: https://github.com/lucidworks/solr-stack
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json e69de29
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json e69de29
Diff: https://reviews.apache.org/r/56508/diff/
Testing
-------
Thanks,
Willy Solaligue