You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/29 14:08:49 UTC

[GitHub] [airflow] zhongjiajie opened a new pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

zhongjiajie opened a new pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593
 
 
   …elated UI
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ x Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#issuecomment-593066992
 
 
   PTAL @kaxil @potiuk @mik-laj

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle merged pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value

Posted by GitBox <gi...@apache.org>.
feluelle merged pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value
URL: https://github.com/apache/airflow/pull/7593
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386094614
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -99,7 +99,8 @@ <h2>DAGs</h2>
                 <!-- Column 3: Name -->
                 <td>
                     <span>
-                      <a href="{{ url_for('Airflow.'+ dag.default_view, dag_id=dag.dag_id) }}" title="{{ dag.description[0:80] + '...' if dag.description|length > 80 else dag.description }}">
+                      <a href="{{ url_for('Airflow.'+ dag.default_view, dag_id=dag.dag_id) }}"
+                         title="{{ dag.description[0:80] + '...' if dag.description and dag.description|length > 80 else dag.description }}">
 
 Review comment:
   Same as above, WDYT

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value
URL: https://github.com/apache/airflow/pull/7593#issuecomment-592953279
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=h1) Report
   > Merging [#7593](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7593/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #7593   +/-   ##
   =======================================
     Coverage   86.93%   86.93%           
   =======================================
     Files         915      915           
     Lines       44158    44158           
   =======================================
     Hits        38387    38387           
     Misses       5771     5771
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7593/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.21% <ø> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=footer). Last update [271ee64...17b608f](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value
URL: https://github.com/apache/airflow/pull/7593#issuecomment-601492360
 
 
   PTAL @ashb @kaxil @potiuk @mik-laj @turbaszek @feluelle

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386094127
 
 

 ##########
 File path: airflow/www/templates/airflow/dag.html
 ##########
 @@ -33,7 +33,8 @@ <h3 class="pull-left">
         <span style='color:#AAA;'>SUBDAG: </span> <span> {{ dag.dag_id }}</span>
       {% else %}
         <input id="pause_resume" dag_id="{{ dag.dag_id }}" type="checkbox" {{ "checked" if not dag.is_paused else "" }} data-toggle="toggle" data-size="mini" method="post">
-        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span> <small class="text-muted"> {{ dag.description }} </small>
+        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span>
+        <small class="text-muted"> description: {{ dag.description[0:150] + '...' if dag.description and dag.description|length > 150 else dag.description }} </small>
 
 Review comment:
   Shouldn't we hide this text when dag.description == None?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value
URL: https://github.com/apache/airflow/pull/7593#issuecomment-592953279
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=h1) Report
   > Merging [#7593](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7593/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #7593   +/-   ##
   =======================================
     Coverage   86.93%   86.93%           
   =======================================
     Files         915      915           
     Lines       44158    44158           
   =======================================
     Hits        38387    38387           
     Misses       5771     5771           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7593/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.21% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=footer). Last update [271ee64...17b608f](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#issuecomment-592953279
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=h1) Report
   > Merging [#7593](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1b38f6d9b6710bd5e25fc16883599f1842ab7cb9?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7593/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #7593   +/-   ##
   =======================================
     Coverage   86.85%   86.85%           
   =======================================
     Files         896      896           
     Lines       42665    42665           
   =======================================
     Hits        37057    37057           
     Misses       5608     5608
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7593/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.57% <ø> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=footer). Last update [1b38f6d...cab2199](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value
URL: https://github.com/apache/airflow/pull/7593#issuecomment-601617775
 
 
   Thanks everyone

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386094127
 
 

 ##########
 File path: airflow/www/templates/airflow/dag.html
 ##########
 @@ -33,7 +33,8 @@ <h3 class="pull-left">
         <span style='color:#AAA;'>SUBDAG: </span> <span> {{ dag.dag_id }}</span>
       {% else %}
         <input id="pause_resume" dag_id="{{ dag.dag_id }}" type="checkbox" {{ "checked" if not dag.is_paused else "" }} data-toggle="toggle" data-size="mini" method="post">
-        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span> <small class="text-muted"> {{ dag.description }} </small>
+        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span>
+        <small class="text-muted"> description: {{ dag.description[0:150] + '...' if dag.description and dag.description|length > 150 else dag.description }} </small>
 
 Review comment:
   Shouldn't we hide this text if dag.description == None?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386094173
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -99,7 +99,8 @@ <h2>DAGs</h2>
                 <!-- Column 3: Name -->
                 <td>
                     <span>
-                      <a href="{{ url_for('Airflow.'+ dag.default_view, dag_id=dag.dag_id) }}" title="{{ dag.description[0:80] + '...' if dag.description|length > 80 else dag.description }}">
+                      <a href="{{ url_for('Airflow.'+ dag.default_view, dag_id=dag.dag_id) }}"
+                         title="{{ dag.description[0:80] + '...' if dag.description and dag.description|length > 80 else dag.description }}">
 
 Review comment:
   Shouldn't we remove the title attribute when dag.description == None?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value
URL: https://github.com/apache/airflow/pull/7593#issuecomment-599185319
 
 
   Fix conflict on UPDATING.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value
URL: https://github.com/apache/airflow/pull/7593#issuecomment-592953279
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=h1) Report
   > Merging [#7593](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7593/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #7593   +/-   ##
   =======================================
     Coverage   86.93%   86.93%           
   =======================================
     Files         915      915           
     Lines       44158    44158           
   =======================================
     Hits        38387    38387           
     Misses       5771     5771           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7593/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.21% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=footer). Last update [271ee64...17b608f](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386109679
 
 

 ##########
 File path: airflow/www/templates/airflow/dag.html
 ##########
 @@ -33,7 +33,8 @@ <h3 class="pull-left">
         <span style='color:#AAA;'>SUBDAG: </span> <span> {{ dag.dag_id }}</span>
       {% else %}
         <input id="pause_resume" dag_id="{{ dag.dag_id }}" type="checkbox" {{ "checked" if not dag.is_paused else "" }} data-toggle="toggle" data-size="mini" method="post">
-        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span> <small class="text-muted"> {{ dag.description }} </small>
+        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span>
+        <small class="text-muted"> description: {{ dag.description[0:150] + '...' if dag.description and dag.description|length > 150 else dag.description }} </small>
 
 Review comment:
   I think it's better to hide it. Some users do not use descriptions, so the repetitive text "None" can be annoying.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#issuecomment-592950147
 
 
   **The detail change as below**
   
   | section                             | old                                                                 | new                                                               |
   | :---------------------------------- | :------------------------------------------------------------------ | :---------------------------------------------------------------- |
   | database                            | empty string ![](https://i.loli.net/2020/02/29/QyXGLTSztmh7vUD.png) | null value ![](https://i.loli.net/2020/02/29/zCwlgTdiyGbkrPB.png) |
   | homepage without description        | ![](https://i.loli.net/2020/02/29/whsLNHFp4YVAdcu.png)              | ![](https://i.loli.net/2020/02/29/mfiKzFgksyancJN.png)            |
   | dag detail page with description    | ![](https://i.loli.net/2020/02/29/CzXxy5tURBnNLDv.png)              | ![](https://i.loli.net/2020/02/29/MN4UX8IPpLWfgiS.png)            |
   | dag detail page without description | ![](https://i.loli.net/2020/02/29/bf1crZd3KJPsMGF.png)              | ![](https://i.loli.net/2020/02/29/SOvmRlchoZPgG1x.png)            |
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386094551
 
 

 ##########
 File path: airflow/www/templates/airflow/dag.html
 ##########
 @@ -33,7 +33,8 @@ <h3 class="pull-left">
         <span style='color:#AAA;'>SUBDAG: </span> <span> {{ dag.dag_id }}</span>
       {% else %}
         <input id="pause_resume" dag_id="{{ dag.dag_id }}" type="checkbox" {{ "checked" if not dag.is_paused else "" }} data-toggle="toggle" data-size="mini" method="post">
-        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span> <small class="text-muted"> {{ dag.description }} </small>
+        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span>
+        <small class="text-muted"> description: {{ dag.description[0:150] + '...' if dag.description and dag.description|length > 150 else dag.description }} </small>
 
 Review comment:
   I want to keep same UI behavior and view, so I did it. Do you think we should hide text

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value
URL: https://github.com/apache/airflow/pull/7593#issuecomment-592953279
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=h1) Report
   > Merging [#7593](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7593/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #7593   +/-   ##
   =======================================
     Coverage   86.93%   86.93%           
   =======================================
     Files         915      915           
     Lines       44158    44158           
   =======================================
     Hits        38387    38387           
     Misses       5771     5771           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7593/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.21% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=footer). Last update [271ee64...17b608f](https://codecov.io/gh/apache/airflow/pull/7593?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386094173
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -99,7 +99,8 @@ <h2>DAGs</h2>
                 <!-- Column 3: Name -->
                 <td>
                     <span>
-                      <a href="{{ url_for('Airflow.'+ dag.default_view, dag_id=dag.dag_id) }}" title="{{ dag.description[0:80] + '...' if dag.description|length > 80 else dag.description }}">
+                      <a href="{{ url_for('Airflow.'+ dag.default_view, dag_id=dag.dag_id) }}"
+                         title="{{ dag.description[0:80] + '...' if dag.description and dag.description|length > 80 else dag.description }}">
 
 Review comment:
   Shouldn't we remove the title attribute if dag.description == None?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on issue #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#issuecomment-592950147
 
 
   **The detail change as below**
   
   **UPDATE AT 2020-03-02**: section `homepage without description` and `dag detail page without description` are same as before.
   
   | section                             | old                                                                 | new                                                               |
   | :---------------------------------- | :------------------------------------------------------------------ | :---------------------------------------------------------------- |
   | database                            | empty string ![](https://i.loli.net/2020/02/29/QyXGLTSztmh7vUD.png) | null value ![](https://i.loli.net/2020/02/29/zCwlgTdiyGbkrPB.png) |
   | ~~homepage without description~~       |              |             |
   | dag detail page with description    | ![](https://i.loli.net/2020/02/29/CzXxy5tURBnNLDv.png)              | ![](https://i.loli.net/2020/02/29/MN4UX8IPpLWfgiS.png)            |
   | ~~dag detail page without description~~ |             |         |
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services