[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42975: [SPARK-45197][CORE] Make `StandaloneRestServer` add `JavaModuleOptions` to drivers

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42975:
URL: https://github.com/apache/spark/pull/42975#discussion_r1328362116


##########
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala:
##########
@@ -124,7 +124,10 @@ private[rest] class StandaloneSubmitRequestServlet(
    * fields used by python applications since python is not supported in standalone
    * cluster mode yet.
    */
-  private def buildDriverDescription(request: CreateSubmissionRequest): DriverDescription = {
+  private[rest] def buildDriverDescription(
+      request: CreateSubmissionRequest,
+      masterUrl: String,
+      masterRestPort: Int): DriverDescription = {

Review Comment:
   This private method is revised for better testing by using dependency injection pattern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org