[GitHub] [ratis] JacksonYao287 commented on a change in pull request #504: RATIS-1402. do not send extra rpc calls to follower when the follower is still installing a snapshot

[GitBox <gi...@apache.org>]

JacksonYao287 commented on a change in pull request #504:
URL: https://github.com/apache/ratis/pull/504#discussion_r720182557



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -1604,12 +1604,14 @@ private InstallSnapshotReplyProto notifyStateMachineToInstallSnapshot(
                     LOG.debug("{}: StateMachine could not install snapshot as it is not available", this);
                   }
                 }
-              // wait until the snapshot is installed successfully or exceptionally
-              }).join();
-        } catch (Throwable t) {
-          inProgressInstallSnapshotRequest.compareAndSet(firstAvailableLogTermIndex, null);
-          throw t;
-        }
+              // wait for 10 seconds for statemachine to install snapshot
+              }).get(10, TimeUnit.SECONDS);

Review comment:
       sure, let us set this to 1 second




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org