You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/21 15:48:17 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
tisonkun opened a new pull request, #16163:
URL: https://github.com/apache/pulsar/pull/16163
### Motivation
This is another attempt to fix #14951 without introduce workaround.
### Modifications
Bump presto.version to 334.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes)
To fix #14951. This version bump should be transparent to users.
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16163:
URL: https://github.com/apache/pulsar/pull/16163#issuecomment-1167060431
@codelipenghui @eolivelli @lhotari could you give this patch a final review and merge if no further concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16163:
URL: https://github.com/apache/pulsar/pull/16163#issuecomment-1162585297
cc @lhotari @codelipenghui
This change comes from https://github.com/apache/pulsar/issues/14951#issuecomment-1083376688. And I touch this module since java-version-trim-agent is the only module uses `java.util.logging` related to [this thread](https://lists.apache.org/thread/65skwo492w2nfjwhb3d9y51roq13h8bs).
Bump dependency version is clear and easy to maintain than introducing an in-place agent module IMO.
cc @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on PR #16163:
URL: https://github.com/apache/pulsar/pull/16163#issuecomment-1163175704
LGTM, there is a similar PR, maybe we could refer to this comment https://github.com/apache/pulsar/pull/14953#pullrequestreview-926492820, if we want to upgrade the Trino version to `334`, it's better to discuss in dev list, because the Trino 334 needs jdk11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16163:
URL: https://github.com/apache/pulsar/pull/16163#issuecomment-1163258354
@gaoran10 Thanks for your inputs! I'm not aware of that PR before. Let me investigate a bit and decide whether to start a thread on dev@ or close this PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16163:
URL: https://github.com/apache/pulsar/pull/16163#issuecomment-1163028388
cc @Technoboy-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16163:
URL: https://github.com/apache/pulsar/pull/16163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16163:
URL: https://github.com/apache/pulsar/pull/16163#issuecomment-1164256982
@eolivelli thanks for your review and information! That sounds great.
ping @gaoran10 @lhotari @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16163:
URL: https://github.com/apache/pulsar/pull/16163#issuecomment-1163274449
@gaoran10 FYI https://lists.apache.org/thread/chhgcb127qmvsfk79f0ry3zh1tz7mfrn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16163:
URL: https://github.com/apache/pulsar/pull/16163#issuecomment-1162655608
All tests has passed at https://github.com/apache/pulsar/runs/6997463530. The latest commit is about test file changes. So I think CPP task failed on flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org