You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:35:55 UTC
[GitHub] [superset] jinghua-qa opened a new issue #15110: [dashboard][3 dot menu] Option of 'toggle fullscreen' should be 'toggle normal screen' in fullscreen mode
jinghua-qa opened a new issue #15110:
URL: https://github.com/apache/superset/issues/15110
when dashboard were toggled fullscreen, the option for toggle back to normal screen should name as something like 'toggle normal screen'
### Expected results
option of toggle to normal screen in dashboard should name as something like 'toggle normal screen' in dashboard 3 dot menu
### Actual results
option of toggle to normal screen in dashboard name as 'toggle fullscreen' in dashboard 3 dot menu now
#### Screenshots
<img width="1792" alt="Screen Shot 2021-06-10 at 10 13 30 PM" src="https://user-images.githubusercontent.com/81597121/121634331-32d99900-ca39-11eb-811d-9d6db867de56.png">
#### How to reproduce the bug
1. Go to dashboard 3 dot menu, click 'toggle fullscreen'
2. After dashboard become fullscreen, click on 3 dot menu again
3. Observe the last option to toggle back to normal screen,
4. See error
### Environment
- superset version: master
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
[Y] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #15110: [dashboard][3 dot menu] Option of 'toggle fullscreen' should be 'toggle normal screen' in fullscreen mode
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #15110:
URL: https://github.com/apache/superset/issues/15110#issuecomment-861478033
closed by: https://github.com/apache/superset/pull/15139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #15110: [dashboard][3 dot menu] Option of 'toggle fullscreen' should be 'toggle normal screen' in fullscreen mode
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #15110:
URL: https://github.com/apache/superset/issues/15110#issuecomment-860118078
@xiezhongfu shall we call 'Enter fullscreen' and 'Exit fullscreen'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie closed issue #15110: [dashboard][3 dot menu] Option of 'toggle fullscreen' should be 'toggle normal screen' in fullscreen mode
Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed issue #15110:
URL: https://github.com/apache/superset/issues/15110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xiezhongfu commented on issue #15110: [dashboard][3 dot menu] Option of 'toggle fullscreen' should be 'toggle normal screen' in fullscreen mode
Posted by GitBox <gi...@apache.org>.
xiezhongfu commented on issue #15110:
URL: https://github.com/apache/superset/issues/15110#issuecomment-860057534
@jinghua-qa I think this is something about semantics. Shall we call `Request fullscreen` and `Exit fullscreen`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15110: [dashboard][3 dot menu] Option of 'toggle fullscreen' should be 'toggle normal screen' in fullscreen mode
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15110:
URL: https://github.com/apache/superset/issues/15110#issuecomment-859662858
@xiezhongfu please take this ticket. let @jinghua-qa know if you have any questions 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15110: [dashboard][3 dot menu] Option of 'toggle fullscreen' should be 'toggle normal screen' in fullscreen mode
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15110:
URL: https://github.com/apache/superset/issues/15110#issuecomment-859662635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org