You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <br...@apache.org> on 2005/11/26 01:31:29 UTC
Re: svn commit: r349047 - /maven/maven-1/plugins/trunk/announcement/plugin.jelly
I think you still need to rollback the other parts othat commit, sa they
are what would be problematic:
> <j:if test="${maven.announcement.mail.from == null}">
>
value="${stringUtils.replace(maven.announcement.mail.subject,
'%VERSION%', versionVariable)}"/>
ltheussl@apache.org wrote:
> Author: ltheussl
> Date: Fri Nov 25 16:28:34 2005
> New Revision: 349047
>
> URL: http://svn.apache.org/viewcvs?rev=349047&view=rev
> Log:
> Remove superfluous maven:get
>
> Modified:
> maven/maven-1/plugins/trunk/announcement/plugin.jelly
>
> Modified: maven/maven-1/plugins/trunk/announcement/plugin.jelly
> URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/announcement/plugin.jelly?rev=349047&r1=349046&r2=349047&view=diff
> ==============================================================================
> --- maven/maven-1/plugins/trunk/announcement/plugin.jelly (original)
> +++ maven/maven-1/plugins/trunk/announcement/plugin.jelly Fri Nov 25 16:28:34 2005
> @@ -42,10 +42,6 @@
>
> <!-- If from email address is empty, find the first non empty email
> address from the POM. -->
> - <maven:get
> - var="maven.announcement.mail.from"
> - plugin="maven-announcement-plugin"
> - property="maven.announcement.mail.from"/>
> <j:if test="${maven.announcement.mail.from == null}">
> <j:forEach var="developer" items="${pom.developers}">
> <j:if test="${not empty(developer.email)}">
> @@ -217,10 +213,6 @@
> <maven:param-check value="${maven.announcement.mail.to}" fail="true">The To address must be specified using the maven.announcement.mail.to property</maven:param-check>
>
> <!-- Resolve dynamic %% templates from maven.announcement.mail.subject -->
> - <maven:get
> - var="maven.announcement.mail.subject"
> - plugin="maven-announcement-plugin"
> - property="maven.announcement.mail.subject"/>
> <j:set var="maven.announcement.mail.subject"
> value="${stringUtils.replace(maven.announcement.mail.subject, '%VERSION%', versionVariable)}"/>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org