Re: [PR] 10.2: Proxy Verifier: use concise stack protocol specification (#13003) [trafficserver]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #13016:
URL: https://github.com/apache/trafficserver/pull/13016#discussion_r2977928265


##########
tests/gold_tests/proxy_protocol/replay/proxy_protocol_in.replay.yaml:
##########
@@ -201,12 +175,8 @@ sessions:
   # Test 4: Verify ATS with :pp: server_ports designation can handle a
   # connection without Proxy Protocol.
   - protocol:
-      - name: http
-        version: 1
       # not sending Proxy Protcol
-      - name: tcp
-      - name: ip
-
+      stack: http

Review Comment:
   Spelling: comment says "Proxy Protcol"; should be "Proxy Protocol".



##########
tests/gold_tests/proxy_protocol/replay/proxy_protocol_in.replay.yaml:
##########
@@ -160,15 +138,11 @@ sessions:
   # Test 3: Incoming PROXY Protocol v1 on TCP port, with arbitrary source and
   # destination address in PROXY message
   - protocol:

Review Comment:
   The test case numbering in comments is inconsistent: after "Test 4" above, this section is labeled "Test 3". Please renumber these headings so they remain sequential (and update subsequent Test 4/Test 5 headings accordingly) to avoid confusion when reading failures.



##########
tests/gold_tests/proxy_protocol/replay/proxy_protocol_in.replay.yaml:
##########
@@ -234,13 +204,8 @@ sessions:
   # Test 5: Verify ATS with :pp: server_ports designation can handle a TLS
   # connection without Proxy Protocol.
   - protocol:
-      - name: http
-        version: 1
-      - name: tls
       # not sending Proxy Protcol
-      - name: tcp
-      - name: ip
-
+      stack: https

Review Comment:
   Spelling: comment says "Proxy Protcol"; should be "Proxy Protocol".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org