You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org> on 2016/04/20 11:02:25 UTC
[jira] [Commented] (SANTUARIO-440) Binary compatiblity broken
between version 2.0.5 and 2.0.4 in
org.apache.xml.security.c14n.CanonicalizationException
[ https://issues.apache.org/jira/browse/SANTUARIO-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249522#comment-15249522 ]
Colm O hEigeartaigh commented on SANTUARIO-440:
-----------------------------------------------
Is there any reason you can't update the code to use the alternative (Exception, String) constructor? The (String, Exception) constructor was removed as it is ambiguous with the existing constructor of (String, Object[]), which performs a different function. I found there were code instances that were passing exceptions through as message parameters instead of storing the exceptions etc.
> Binary compatiblity broken between version 2.0.5 and 2.0.4 in org.apache.xml.security.c14n.CanonicalizationException
> --------------------------------------------------------------------------------------------------------------------
>
> Key: SANTUARIO-440
> URL: https://issues.apache.org/jira/browse/SANTUARIO-440
> Project: Santuario
> Issue Type: Bug
> Components: Java
> Affects Versions: Java 2.0.5, Java 2.0.6
> Environment: Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Apache Ant(TM) version 1.9.7 compiled on April 9 2016
> Apache Ivy 2.4.0.
> Reporter: Gary Gregory
> Assignee: Colm O hEigeartaigh
> Priority: Blocker
> Attachments: SANTUARIO-440.diff
>
>
> Hi All,
> Binary compatibility has been broken between version 2.0.4 and 2.0.5 in org.apache.xml.security.c14n.CanonicalizationException.
> The CanonicalizationException ctor (String, Exception) has been removed!
> Please restore!
> Gary
> {noformat}
> >svn diff https://svn.apache.org/repos/asf/santuario/xml-security-java/tags/xmlsec-2.0.4/src/main/java/org/apache/xml/security/c14n/CanonicalizationException.java https://svn.apache.org/repos/asf/santuario/xml-security-java/tags/xmlsec-2.0.5/src/main
> /java/org/apache/xml/security/c14n/CanonicalizationException.java
> Index: CanonicalizationException.java
> ===================================================================
> --- CanonicalizationException.java (.../xmlsec-2.0.4/src/main/java/org/apache/xml/security/c14n/CanonicalizationException.java) (revision 1740035)
> +++ CanonicalizationException.java (.../xmlsec-2.0.5/src/main/java/org/apache/xml/security/c14n/CanonicalizationException.java) (revision 1740035)
> @@ -39,6 +39,10 @@
> public CanonicalizationException() {
> super();
> }
> +
> + public CanonicalizationException(Exception ex) {
> + super(ex);
> + }
> /**
> * Constructor CanonicalizationException
> @@ -62,23 +66,23 @@
> /**
> * Constructor CanonicalizationException
> *
> + * @param originalException
> * @param msgID
> - * @param originalException
> */
> - public CanonicalizationException(String msgID, Exception originalException) {
> - super(msgID, originalException);
> + public CanonicalizationException(Exception originalException, String msgID) {
> + super(originalException, msgID);
> }
> /**
> * Constructor CanonicalizationException
> *
> + * @param originalException
> * @param msgID
> * @param exArgs
> - * @param originalException
> */
> public CanonicalizationException(
> - String msgID, Object exArgs[], Exception originalException
> + Exception originalException, String msgID, Object exArgs[]
> ) {
> - super(msgID, exArgs, originalException);
> + super(originalException, msgID, exArgs);
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)