You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "smallhibiscus (via GitHub)" <gi...@apache.org> on 2024/02/06 08:16:04 UTC
[PR] [refactor](load) Support loader with copy into [doris-spark-connector]
smallhibiscus opened a new pull request, #190:
URL: https://github.com/apache/doris-spark-connector/pull/190
# Proposed changes
In order to import and adapt selectdb, i introduced the `copy into` import method in the connector.
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](load) Support loader with copy into [doris-spark-connector]
Posted by "smallhibiscus (via GitHub)" <gi...@apache.org>.
smallhibiscus commented on PR #190:
URL: https://github.com/apache/doris-spark-connector/pull/190#issuecomment-1951060520
@JNSimba @gnehil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](load) Support loader with copy into [doris-spark-connector]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #190:
URL: https://github.com/apache/doris-spark-connector/pull/190#discussion_r1493972848
##########
spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java:
##########
@@ -144,4 +144,10 @@ public interface ConfigurationOptions {
String DORIS_HTTPS_KEY_STORE_PASSWORD = "doris.https.key-store-password";
+ String LOAD_MODE = "doris.sink.load.mode";
+ String DEFAULT_LOAD_MODE = "stream_load";
+
+ String CLUSTER_NAME = "sink.clustername";
Review Comment:
Should this be optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](load) Support loader with copy into [doris-spark-connector]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #190:
URL: https://github.com/apache/doris-spark-connector/pull/190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org