[GitHub] [maven] michael-o commented on a diff in pull request #944: [MNG-7652] swtich to Modello Velocity

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #944:
URL: https://github.com/apache/maven/pull/944#discussion_r1059784940


##########
api/maven-api-model/pom.xml:
##########
@@ -63,26 +63,26 @@ under the License.
         </executions>
       </plugin>
       <plugin>
-        <groupId>org.apache.maven</groupId>
-        <artifactId>modello-plugin-velocity</artifactId>
-        <configuration>
-          <version>4.2.0</version>
-          <models>
-            <model>src/main/mdo/maven.mdo</model>
-          </models>
-          <templates>
-            <template>src/main/mdo/model.vm</template>
-          </templates>
-          <params>
-            <param>packageModelV4=org.apache.maven.api.model</param>
-          </params>
-        </configuration>
+        <groupId>org.codehaus.modello</groupId>
+        <artifactId>modello-maven-plugin</artifactId>
         <executions>
           <execution>
-            <id>modello</id>
+            <id>velocity</id>
             <goals>
               <goal>velocity</goal>
             </goals>
+            <configuration>
+              <version>4.2.0</version>
+              <models>
+                <model>src/main/mdo/maven.mdo</model>
+              </models>
+              <templates>
+                <template>src/main/mdo/model.vm</template>
+              </templates>

Review Comment:
   Stupid question, do we need this separation between main and test for models at all?



##########
api/pom.xml:
##########
@@ -45,6 +44,27 @@
     <project.directory>api</project.directory>
   </properties>
 
+  <build>
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <groupId>org.codehaus.modello</groupId>
+          <artifactId>modello-maven-plugin</artifactId>
+          <executions>
+            <execution>
+              <id>modello-site-docs</id>
+              <goals>
+                <goal>xdoc</goal>
+                <goal>xsd</goal>
+              </goals>
+              <phase>none</phase>

Review Comment:
   This works?



##########
api/maven-api-model/src/main/mdo/model.vm:
##########
@@ -85,7 +85,7 @@
       #end
     #end
 // =================== DO NOT EDIT THIS FILE ====================
-//   Generated by Maven, any modifications will be overwritten.
+//   ${generatedBy}

Review Comment:
   This I would like to know as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org