You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafodion.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/06 19:17:00 UTC

[jira] [Commented] (TRAFODION-2678) privileges regression tests privs1/TEST040-44 output non-printable characters

    [ https://issues.apache.org/jira/browse/TRAFODION-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077091#comment-16077091 ] 

ASF GitHub Bot commented on TRAFODION-2678:
-------------------------------------------

GitHub user zellerh opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1168

    [TRAFODION-2678] non-printable characters in log files

    The UDF used in these tests would insert a NUL character in
    the logs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zellerh/incubator-trafodion bug/r2.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1168
    
----
commit 4c23d1c2cf068cb1b9e723a819d054c213dfaabf
Author: Hans Zeller <hz...@apache.org>
Date:   2017-07-06T19:06:52Z

    [TRAFODION-2678] non-printable characters in log files
    
    The UDF used in these tests would insert a NUL character in
    the logs.

----


> privileges regression tests privs1/TEST040-44 output non-printable characters
> -----------------------------------------------------------------------------
>
>                 Key: TRAFODION-2678
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2678
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: sql-security
>    Affects Versions: 2.2-incubating
>            Reporter: Hans Zeller
>            Assignee: Hans Zeller
>            Priority: Minor
>             Fix For: 2.2-incubating
>
>
> While updating an expected file for privs2/TEST144 I found that git treats these files as binary files. It turns out that a UDF that's used to display privilege information puts a NUL caracter into the output. This also causes the text to be truncated before we compare it (maybe in logsort or in the regression filter).
> The fix is simple: Don't put the terminating NUL into the output value of the UDF.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)