You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sergeyuttsel (via GitHub)" <gi...@apache.org> on 2023/05/16 12:58:26 UTC
[GitHub] [ignite-3] sergeyuttsel opened a new pull request, #2077: IGNITE-19255 Some tests from DistributionZoneManagerScaleUpTest were fixed and enabled.
sergeyuttsel opened a new pull request, #2077:
URL: https://github.com/apache/ignite-3/pull/2077
https://issues.apache.org/jira/browse/IGNITE-19255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc merged pull request #2077: IGNITE-19255 Some tests from DistributionZoneManagerScaleUpTest were fixed and enabled.
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc merged PR #2077:
URL: https://github.com/apache/ignite-3/pull/2077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2077: IGNITE-19255 Some tests from DistributionZoneManagerScaleUpTest were fixed and enabled.
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #2077:
URL: https://github.com/apache/ignite-3/pull/2077#discussion_r1196014891
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -95,8 +93,6 @@ void testDataNodesPropagationAfterScaleUpTriggered() throws Exception {
Set<LogicalNode> clusterNodes = Set.of(NODE_1);
- mockVaultZonesLogicalTopologyKey(clusterNodes);
Review Comment:
Why did we remove such mocks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2077: IGNITE-19255 Some tests from DistributionZoneManagerScaleUpTest were fixed and enabled.
Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel commented on code in PR #2077:
URL: https://github.com/apache/ignite-3/pull/2077#discussion_r1196333937
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -95,8 +93,6 @@ void testDataNodesPropagationAfterScaleUpTriggered() throws Exception {
Set<LogicalNode> clusterNodes = Set.of(NODE_1);
- mockVaultZonesLogicalTopologyKey(clusterNodes);
Review Comment:
Because no need to initialized logicalTopology with the same value from the `topology` and from the vault. So I decided to remove excessive mocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2077: IGNITE-19255 Some tests from DistributionZoneManagerScaleUpTest were fixed and enabled.
Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel commented on code in PR #2077:
URL: https://github.com/apache/ignite-3/pull/2077#discussion_r1196333937
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -95,8 +93,6 @@ void testDataNodesPropagationAfterScaleUpTriggered() throws Exception {
Set<LogicalNode> clusterNodes = Set.of(NODE_1);
- mockVaultZonesLogicalTopologyKey(clusterNodes);
Review Comment:
Because no need to initialize logicalTopology with the same value from the `topology` and from the vault. So I decided to remove excessive mocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org